minor #6298 Update dependency_injection.rst because it has an error. (joserprieto)

xabbuh · xabbuh · commit a499d1260c6a · 2016-02-27T17:40:01.000+01:00
This PR was submitted for the 3.0 branch but it was merged into the 2.8 branch instead (closes #6298). Discussion ---------- Update dependency_injection.rst because it has an error. The line: $sc->register('listener.router', 'Symfony\Component\HttpKernel\EventListener\RouterListener') ->setArguments(array(new Reference('matcher'))) ; is wrong, because the Symfony\Component\HttpKernel\EventListener\ResponseListener has two mandatory arguments; an instance of Symfony\Component\Routing\Matcher\UrlMatcher (or RequestMatcher), and an instance of RequestStack; so, we need to add the line: $sc->register('request_stack', 'Symfony\Component\HttpFoundation\RequestStack'); And change the registration of listener.router on this form: $sc->register('listener.router', 'Symfony\Component\HttpKernel\EventListener\RouterListener') ->setArguments(array(new Reference('matcher'), new Reference('request_stack'))) ; Commits ------- 06eee41 Update dependency_injection.rst because it has an error.
diff --git a/create_framework/dependency_injection.rst b/create_framework/dependency_injection.rst
@@ -100,10 +100,11 @@ Create a new file to host the dependency injection container configuration::
     $sc->register('matcher', 'Symfony\Component\Routing\Matcher\UrlMatcher')
         ->setArguments(array($routes, new Reference('context')))
     ;
+    $sc->register('request_stack', 'Symfony\Component\HttpFoundation\RequestStack');
     $sc->register('resolver', 'Symfony\Component\HttpKernel\Controller\ControllerResolver');
 
     $sc->register('listener.router', 'Symfony\Component\HttpKernel\EventListener\RouterListener')
-        ->setArguments(array(new Reference('matcher')))
+        ->setArguments(array(new Reference('matcher'), new Reference('request_stack')))
     ;
     $sc->register('listener.response', 'Symfony\Component\HttpKernel\EventListener\ResponseListener')
         ->setArguments(array('UTF-8'))

Original file line number	Diff line number	Diff line change
`@@ -100,10 +100,11 @@ Create a new file to host the dependency injection container configuration::`
`100`	`100`	`$sc->register('matcher', 'Symfony\Component\Routing\Matcher\UrlMatcher')`
`101`	`101`	`->setArguments(array($routes, new Reference('context')))`
`102`	`102`	`;`
	`103`	`+ $sc->register('request_stack', 'Symfony\Component\HttpFoundation\RequestStack');`
`103`	`104`	`$sc->register('resolver', 'Symfony\Component\HttpKernel\Controller\ControllerResolver');`
`104`	`105`
`105`	`106`	`$sc->register('listener.router', 'Symfony\Component\HttpKernel\EventListener\RouterListener')`
`106`		`- ->setArguments(array(new Reference('matcher')))`
	`107`	`+ ->setArguments(array(new Reference('matcher'), new Reference('request_stack')))`
`107`	`108`	`;`
`108`	`109`	`$sc->register('listener.response', 'Symfony\Component\HttpKernel\EventListener\ResponseListener')`
`109`	`110`	`->setArguments(array('UTF-8'))`