Merge branch '5.4' into 6.3

nicolas-grekas · nicolas-grekas · commit 5270fc8f3bc2 · 2024-01-23T15:35:58.000+01:00
* 5.4:
  Fix implicitly-required parameters
  List CS fix in .git-blame-ignore-revs
  Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value
  [Messenger][AmazonSqs] Allow async-aws/sqs version 2
diff --git a/Definition.php b/Definition.php
@@ -32,7 +32,7 @@ final class Definition
      * @param Transition[]         $transitions
      * @param string|string[]|null $initialPlaces
      */
-    public function __construct(array $places, array $transitions, string|array $initialPlaces = null, MetadataStoreInterface $metadataStore = null)
+    public function __construct(array $places, array $transitions, string|array|null $initialPlaces = null, ?MetadataStoreInterface $metadataStore = null)
     {
         foreach ($places as $place) {
             $this->addPlace($place);
@@ -76,7 +76,7 @@ public function getMetadataStore(): MetadataStoreInterface
         return $this->metadataStore;
     }
 
-    private function setInitialPlaces(string|array $places = null): void
+    private function setInitialPlaces(string|array|null $places = null): void
     {
         if (1 > \func_num_args()) {
             trigger_deprecation('symfony/workflow', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
diff --git a/Dumper/DumperInterface.php b/Dumper/DumperInterface.php
@@ -25,5 +25,5 @@ interface DumperInterface
     /**
      * Dumps a workflow definition.
      */
-    public function dump(Definition $definition, Marking $marking = null, array $options = []): string;
+    public function dump(Definition $definition, ?Marking $marking = null, array $options = []): string;
 }
diff --git a/Dumper/GraphvizDumper.php b/Dumper/GraphvizDumper.php
@@ -42,7 +42,7 @@ class GraphvizDumper implements DumperInterface
      *  * node: The default options for nodes (places + transitions)
      *  * edge: The default options for edges
      */
-    public function dump(Definition $definition, Marking $marking = null, array $options = []): string
+    public function dump(Definition $definition, ?Marking $marking = null, array $options = []): string
     {
         $places = $this->findPlaces($definition, $marking);
         $transitions = $this->findTransitions($definition);
@@ -60,7 +60,7 @@ public function dump(Definition $definition, Marking $marking = null, array $opt
     /**
      * @internal
      */
-    protected function findPlaces(Definition $definition, Marking $marking = null): array
+    protected function findPlaces(Definition $definition, ?Marking $marking = null): array
     {
         $workflowMetadata = $definition->getMetadataStore();
 
diff --git a/Dumper/MermaidDumper.php b/Dumper/MermaidDumper.php
@@ -57,7 +57,7 @@ public function __construct(string $transitionType, string $direction = self::DI
         $this->transitionType = $transitionType;
     }
 
-    public function dump(Definition $definition, Marking $marking = null, array $options = []): string
+    public function dump(Definition $definition, ?Marking $marking = null, array $options = []): string
     {
         $this->linkCount = 0;
         $placeNameMap = [];
diff --git a/Dumper/PlantUmlDumper.php b/Dumper/PlantUmlDumper.php
@@ -61,7 +61,7 @@ public function __construct(string $transitionType)
         $this->transitionType = $transitionType;
     }
 
-    public function dump(Definition $definition, Marking $marking = null, array $options = []): string
+    public function dump(Definition $definition, ?Marking $marking = null, array $options = []): string
     {
         $options = array_replace_recursive(self::DEFAULT_OPTIONS, $options);
 
@@ -191,7 +191,7 @@ private function escape(string $string): string
         return '"'.str_replace('"', '', $string).'"';
     }
 
-    private function getState(string $place, Definition $definition, Marking $marking = null): string
+    private function getState(string $place, Definition $definition, ?Marking $marking = null): string
     {
         $workflowMetadata = $definition->getMetadataStore();
 
diff --git a/Dumper/StateMachineGraphvizDumper.php b/Dumper/StateMachineGraphvizDumper.php
@@ -25,7 +25,7 @@ class StateMachineGraphvizDumper extends GraphvizDumper
      *  * node: The default options for nodes (places)
      *  * edge: The default options for edges
      */
-    public function dump(Definition $definition, Marking $marking = null, array $options = []): string
+    public function dump(Definition $definition, ?Marking $marking = null, array $options = []): string
     {
         $places = $this->findPlaces($definition, $marking);
         $edges = $this->findEdges($definition);
diff --git a/Event/Event.php b/Event/Event.php
@@ -29,7 +29,7 @@ class Event extends BaseEvent
     private ?Transition $transition;
     private ?WorkflowInterface $workflow;
 
-    public function __construct(object $subject, Marking $marking, Transition $transition = null, WorkflowInterface $workflow = null, array $context = [])
+    public function __construct(object $subject, Marking $marking, ?Transition $transition = null, ?WorkflowInterface $workflow = null, array $context = [])
     {
         $this->subject = $subject;
         $this->marking = $marking;
diff --git a/Event/GuardEvent.php b/Event/GuardEvent.php
@@ -25,7 +25,7 @@ final class GuardEvent extends Event
 {
     private TransitionBlockerList $transitionBlockerList;
 
-    public function __construct(object $subject, Marking $marking, Transition $transition, WorkflowInterface $workflow = null)
+    public function __construct(object $subject, Marking $marking, Transition $transition, ?WorkflowInterface $workflow = null)
     {
         parent::__construct($subject, $marking, $transition, $workflow);
 
@@ -42,7 +42,7 @@ public function isBlocked(): bool
         return !$this->transitionBlockerList->isEmpty();
     }
 
-    public function setBlocked(bool $blocked, string $message = null): void
+    public function setBlocked(bool $blocked, ?string $message = null): void
     {
         if (!$blocked) {
             $this->transitionBlockerList->clear();
diff --git a/EventListener/GuardListener.php b/EventListener/GuardListener.php
@@ -32,7 +32,7 @@ class GuardListener
     private ?RoleHierarchyInterface $roleHierarchy;
     private ?ValidatorInterface $validator;
 
-    public function __construct(array $configuration, ExpressionLanguage $expressionLanguage, TokenStorageInterface $tokenStorage, AuthorizationCheckerInterface $authorizationChecker, AuthenticationTrustResolverInterface $trustResolver, RoleHierarchyInterface $roleHierarchy = null, ValidatorInterface $validator = null)
+    public function __construct(array $configuration, ExpressionLanguage $expressionLanguage, TokenStorageInterface $tokenStorage, AuthorizationCheckerInterface $authorizationChecker, AuthenticationTrustResolverInterface $trustResolver, ?RoleHierarchyInterface $roleHierarchy = null, ?ValidatorInterface $validator = null)
     {
         $this->configuration = $configuration;
         $this->expressionLanguage = $expressionLanguage;
diff --git a/Metadata/GetMetadataTrait.php b/Metadata/GetMetadataTrait.php
@@ -21,7 +21,7 @@ trait GetMetadataTrait
     /**
      * @return mixed
      */
-    public function getMetadata(string $key, string|Transition $subject = null)
+    public function getMetadata(string $key, string|Transition|null $subject = null)
     {
         if (null === $subject) {
             return $this->getWorkflowMetadata()[$key] ?? null;
diff --git a/Metadata/InMemoryMetadataStore.php b/Metadata/InMemoryMetadataStore.php
@@ -27,7 +27,7 @@ final class InMemoryMetadataStore implements MetadataStoreInterface
     /**
      * @param \SplObjectStorage<Transition, array>|null $transitionsMetadata
      */
-    public function __construct(array $workflowMetadata = [], array $placesMetadata = [], \SplObjectStorage $transitionsMetadata = null)
+    public function __construct(array $workflowMetadata = [], array $placesMetadata = [], ?\SplObjectStorage $transitionsMetadata = null)
     {
         $this->workflowMetadata = $workflowMetadata;
         $this->placesMetadata = $placesMetadata;
diff --git a/Metadata/MetadataStoreInterface.php b/Metadata/MetadataStoreInterface.php
@@ -37,5 +37,5 @@ public function getTransitionMetadata(Transition $transition): array;
      *
      * @return mixed
      */
-    public function getMetadata(string $key, string|Transition $subject = null);
+    public function getMetadata(string $key, string|Transition|null $subject = null);
 }
diff --git a/Registry.php b/Registry.php
@@ -32,7 +32,7 @@ public function addWorkflow(WorkflowInterface $workflow, WorkflowSupportStrategy
         $this->workflows[] = [$workflow, $supportStrategy];
     }
 
-    public function has(object $subject, string $workflowName = null): bool
+    public function has(object $subject, ?string $workflowName = null): bool
     {
         foreach ($this->workflows as [$workflow, $supportStrategy]) {
             if ($this->supports($workflow, $supportStrategy, $subject, $workflowName)) {
@@ -43,7 +43,7 @@ public function has(object $subject, string $workflowName = null): bool
         return false;
     }
 
-    public function get(object $subject, string $workflowName = null): Workflow
+    public function get(object $subject, ?string $workflowName = null): Workflow
     {
         $matched = [];
 
diff --git a/StateMachine.php b/StateMachine.php
@@ -20,7 +20,7 @@
  */
 class StateMachine extends Workflow
 {
-    public function __construct(Definition $definition, MarkingStoreInterface $markingStore = null, EventDispatcherInterface $dispatcher = null, string $name = 'unnamed', array $eventsToDispatch = null)
+    public function __construct(Definition $definition, ?MarkingStoreInterface $markingStore = null, ?EventDispatcherInterface $dispatcher = null, string $name = 'unnamed', ?array $eventsToDispatch = null)
     {
         parent::__construct($definition, $markingStore ?? new MethodMarkingStore(true), $dispatcher, $name, $eventsToDispatch);
     }
diff --git a/Tests/EventListener/GuardListenerTest.php b/Tests/EventListener/GuardListenerTest.php
@@ -143,7 +143,7 @@ public function testGuardExpressionBlocks()
         $this->assertTrue($event->isBlocked());
     }
 
-    private function createEvent(Transition $transition = null): GuardEvent
+    private function createEvent(?Transition $transition = null): GuardEvent
     {
         $subject = new Subject();
         $transition ??= new Transition('name', 'from', 'to');
diff --git a/Tests/WorkflowTest.php b/Tests/WorkflowTest.php
@@ -782,7 +782,7 @@ class EventDispatcherMock implements \Symfony\Contracts\EventDispatcher\EventDis
 {
     public $dispatchedEvents = [];
 
-    public function dispatch($event, string $eventName = null): object
+    public function dispatch($event, ?string $eventName = null): object
     {
         $this->dispatchedEvents[] = $eventName;
 
diff --git a/TransitionBlocker.php b/TransitionBlocker.php
@@ -67,7 +67,7 @@ public static function createBlockedByExpressionGuardListener(string $expression
      * Creates a blocker that says the transition cannot be made because of an
      * unknown reason.
      */
-    public static function createUnknown(string $message = null, int $backtraceFrame = 2): self
+    public static function createUnknown(?string $message = null, int $backtraceFrame = 2): self
     {
         if (null !== $message) {
             return new static($message, self::UNKNOWN);
diff --git a/Workflow.php b/Workflow.php
@@ -67,7 +67,7 @@ class Workflow implements WorkflowInterface
      */
     private ?array $eventsToDispatch = null;
 
-    public function __construct(Definition $definition, MarkingStoreInterface $markingStore = null, EventDispatcherInterface $dispatcher = null, string $name = 'unnamed', array $eventsToDispatch = null)
+    public function __construct(Definition $definition, ?MarkingStoreInterface $markingStore = null, ?EventDispatcherInterface $dispatcher = null, string $name = 'unnamed', ?array $eventsToDispatch = null)
     {
         $this->definition = $definition;
         $this->markingStore = $markingStore ?? new MethodMarkingStore();

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ final class Definition`
`32`	`32`	`* @param Transition[] $transitions`
`33`	`33`	`* @param string\|string[]\|null $initialPlaces`
`34`	`34`	`*/`
`35`		`- public function __construct(array $places, array $transitions, string\|array $initialPlaces = null, MetadataStoreInterface $metadataStore = null)`
	`35`	`+ public function __construct(array $places, array $transitions, string\|array\|null $initialPlaces = null, ?MetadataStoreInterface $metadataStore = null)`
`36`	`36`	`{`
`37`	`37`	`foreach ($places as $place) {`
`38`	`38`	`$this->addPlace($place);`
`@@ -76,7 +76,7 @@ public function getMetadataStore(): MetadataStoreInterface`
`76`	`76`	`return $this->metadataStore;`
`77`	`77`	`}`
`78`	`78`
`79`		`- private function setInitialPlaces(string\|array $places = null): void`
	`79`	`+ private function setInitialPlaces(string\|array\|null $places = null): void`
`80`	`80`	`{`
`81`	`81`	`if (1 > \func_num_args()) {`
`82`	`82`	`trigger_deprecation('symfony/workflow', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);`
Original file line number	Diff line number	Diff line change
`@@ -25,5 +25,5 @@ interface DumperInterface`
`25`	`25`	`/**`
`26`	`26`	`* Dumps a workflow definition.`
`27`	`27`	`*/`
`28`		`- public function dump(Definition $definition, Marking $marking = null, array $options = []): string;`
	`28`	`+ public function dump(Definition $definition, ?Marking $marking = null, array $options = []): string;`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public function __construct(string $transitionType, string $direction = self::DI`
`57`	`57`	`$this->transitionType = $transitionType;`
`58`	`58`	`}`
`59`	`59`
`60`		`- public function dump(Definition $definition, Marking $marking = null, array $options = []): string`
	`60`	`+ public function dump(Definition $definition, ?Marking $marking = null, array $options = []): string`
`61`	`61`	`{`
`62`	`62`	`$this->linkCount = 0;`
`63`	`63`	`$placeNameMap = [];`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public function __construct(string $transitionType)`
`61`	`61`	`$this->transitionType = $transitionType;`
`62`	`62`	`}`
`63`	`63`
`64`		`- public function dump(Definition $definition, Marking $marking = null, array $options = []): string`
	`64`	`+ public function dump(Definition $definition, ?Marking $marking = null, array $options = []): string`
`65`	`65`	`{`
`66`	`66`	`$options = array_replace_recursive(self::DEFAULT_OPTIONS, $options);`
`67`	`67`
`@@ -191,7 +191,7 @@ private function escape(string $string): string`
`191`	`191`	`return '"'.str_replace('"', '', $string).'"';`
`192`	`192`	`}`
`193`	`193`
`194`		`- private function getState(string $place, Definition $definition, Marking $marking = null): string`
	`194`	`+ private function getState(string $place, Definition $definition, ?Marking $marking = null): string`
`195`	`195`	`{`
`196`	`196`	`$workflowMetadata = $definition->getMetadataStore();`
`197`	`197`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class StateMachineGraphvizDumper extends GraphvizDumper`
`25`	`25`	`* * node: The default options for nodes (places)`
`26`	`26`	`* * edge: The default options for edges`
`27`	`27`	`*/`
`28`		`- public function dump(Definition $definition, Marking $marking = null, array $options = []): string`
	`28`	`+ public function dump(Definition $definition, ?Marking $marking = null, array $options = []): string`
`29`	`29`	`{`
`30`	`30`	`$places = $this->findPlaces($definition, $marking);`
`31`	`31`	`$edges = $this->findEdges($definition);`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class Event extends BaseEvent`
`29`	`29`	`private ?Transition $transition;`
`30`	`30`	`private ?WorkflowInterface $workflow;`
`31`	`31`
`32`		`- public function __construct(object $subject, Marking $marking, Transition $transition = null, WorkflowInterface $workflow = null, array $context = [])`
	`32`	`+ public function __construct(object $subject, Marking $marking, ?Transition $transition = null, ?WorkflowInterface $workflow = null, array $context = [])`
`33`	`33`	`{`
`34`	`34`	`$this->subject = $subject;`
`35`	`35`	`$this->marking = $marking;`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ final class GuardEvent extends Event`
`25`	`25`	`{`
`26`	`26`	`private TransitionBlockerList $transitionBlockerList;`
`27`	`27`
`28`		`- public function __construct(object $subject, Marking $marking, Transition $transition, WorkflowInterface $workflow = null)`
	`28`	`+ public function __construct(object $subject, Marking $marking, Transition $transition, ?WorkflowInterface $workflow = null)`
`29`	`29`	`{`
`30`	`30`	`parent::__construct($subject, $marking, $transition, $workflow);`
`31`	`31`
`@@ -42,7 +42,7 @@ public function isBlocked(): bool`
`42`	`42`	`return !$this->transitionBlockerList->isEmpty();`
`43`	`43`	`}`
`44`	`44`
`45`		`- public function setBlocked(bool $blocked, string $message = null): void`
	`45`	`+ public function setBlocked(bool $blocked, ?string $message = null): void`
`46`	`46`	`{`
`47`	`47`	`if (!$blocked) {`
`48`	`48`	`$this->transitionBlockerList->clear();`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ class GuardListener`
`32`	`32`	`private ?RoleHierarchyInterface $roleHierarchy;`
`33`	`33`	`private ?ValidatorInterface $validator;`
`34`	`34`
`35`		`- public function __construct(array $configuration, ExpressionLanguage $expressionLanguage, TokenStorageInterface $tokenStorage, AuthorizationCheckerInterface $authorizationChecker, AuthenticationTrustResolverInterface $trustResolver, RoleHierarchyInterface $roleHierarchy = null, ValidatorInterface $validator = null)`
	`35`	`+ public function __construct(array $configuration, ExpressionLanguage $expressionLanguage, TokenStorageInterface $tokenStorage, AuthorizationCheckerInterface $authorizationChecker, AuthenticationTrustResolverInterface $trustResolver, ?RoleHierarchyInterface $roleHierarchy = null, ?ValidatorInterface $validator = null)`
`36`	`36`	`{`
`37`	`37`	`$this->configuration = $configuration;`
`38`	`38`	`$this->expressionLanguage = $expressionLanguage;`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ trait GetMetadataTrait`
`21`	`21`	`/**`
`22`	`22`	`* @return mixed`
`23`	`23`	`*/`
`24`		`- public function getMetadata(string $key, string\|Transition $subject = null)`
	`24`	`+ public function getMetadata(string $key, string\|Transition\|null $subject = null)`
`25`	`25`	`{`
`26`	`26`	`if (null === $subject) {`
`27`	`27`	`return $this->getWorkflowMetadata()[$key] ?? null;`