Remove useless code

alexandre-daubois · alexandre-daubois · commit a370dba51fe7 · 2024-08-08T12:05:06.000+02:00
diff --git a/Dumper/PlantUmlDumper.php b/Dumper/PlantUmlDumper.php
@@ -115,23 +115,20 @@ public function dump(Definition $definition, ?Marking $marking = null, array $op
             }
         }
 
-        return $this->startPuml($options).$this->getLines($code).$this->endPuml($options);
+        return $this->startPuml().$this->getLines($code).$this->endPuml();
     }
 
     private function isWorkflowTransitionType(): bool
     {
         return self::WORKFLOW_TRANSITION === $this->transitionType;
     }
 
-    private function startPuml(array $options): string
+    private function startPuml(): string
     {
-        $start = '@startuml'.\PHP_EOL;
-        $start .= 'allow_mixing'.\PHP_EOL;
-
-        return $start;
+        return '@startuml'.\PHP_EOL.'allow_mixing'.\PHP_EOL;
     }
 
-    private function endPuml(array $options): string
+    private function endPuml(): string
     {
         return \PHP_EOL.'@enduml';
     }

Original file line number	Diff line number	Diff line change
`@@ -115,23 +115,20 @@ public function dump(Definition $definition, ?Marking $marking = null, array $op`
`115`	`115`	`}`
`116`	`116`	`}`
`117`	`117`
`118`		`- return $this->startPuml($options).$this->getLines($code).$this->endPuml($options);`
	`118`	`+ return $this->startPuml().$this->getLines($code).$this->endPuml();`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`private function isWorkflowTransitionType(): bool`
`122`	`122`	`{`
`123`	`123`	`return self::WORKFLOW_TRANSITION === $this->transitionType;`
`124`	`124`	`}`
`125`	`125`
`126`		`- private function startPuml(array $options): string`
	`126`	`+ private function startPuml(): string`
`127`	`127`	`{`
`128`		`- $start = '@startuml'.\PHP_EOL;`
`129`		`- $start .= 'allow_mixing'.\PHP_EOL;`
`130`		`-`
`131`		`- return $start;`
	`128`	`+ return '@startuml'.\PHP_EOL.'allow_mixing'.\PHP_EOL;`
`132`	`129`	`}`
`133`	`130`
`134`		`- private function endPuml(array $options): string`
	`131`	`+ private function endPuml(): string`
`135`	`132`	`{`
`136`	`133`	`return \PHP_EOL.'@enduml';`
`137`	`134`	`}`