Don't enable tracing unless the profiler is enabled

nicolas-grekas · nicolas-grekas · commit cd0203f9b3ad · 2025-04-22T11:11:45.000+02:00
diff --git a/Debug/TraceableWorkflow.php b/Debug/TraceableWorkflow.php
@@ -30,6 +30,7 @@ class TraceableWorkflow implements WorkflowInterface
     public function __construct(
         private readonly WorkflowInterface $workflow,
         private readonly Stopwatch $stopwatch,
+        protected readonly ?\Closure $disabled = null,
     ) {
     }
 
@@ -90,6 +91,9 @@ public function getCalls(): array
 
     private function callInner(string $method, array $args): mixed
     {
+        if ($this->disabled?->__invoke()) {
+            return $this->workflow->{$method}(...$args);
+        }
         $sMethod = $this->workflow::class.'::'.$method;
         $this->stopwatch->start($sMethod, 'workflow');
 
diff --git a/DependencyInjection/WorkflowDebugPass.php b/DependencyInjection/WorkflowDebugPass.php
@@ -31,6 +31,7 @@ public function process(ContainerBuilder $container): void
                 ->setArguments([
                     new Reference("debug.{$id}.inner"),
                     new Reference('debug.stopwatch'),
+                    new Reference('profiler.is_disabled_state_checker', ContainerBuilder::IGNORE_ON_INVALID_REFERENCE),
                 ]);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ class TraceableWorkflow implements WorkflowInterface`
`30`	`30`	`public function __construct(`
`31`	`31`	`private readonly WorkflowInterface $workflow,`
`32`	`32`	`private readonly Stopwatch $stopwatch,`
	`33`	`+ protected readonly ?\Closure $disabled = null,`
`33`	`34`	`) {`
`34`	`35`	`}`
`35`	`36`
`@@ -90,6 +91,9 @@ public function getCalls(): array`
`90`	`91`
`91`	`92`	`private function callInner(string $method, array $args): mixed`
`92`	`93`	`{`
	`94`	`+ if ($this->disabled?->__invoke()) {`
	`95`	`+ return $this->workflow->{$method}(...$args);`
	`96`	`+ }`
`93`	`97`	`$sMethod = $this->workflow::class.'::'.$method;`
`94`	`98`	`$this->stopwatch->start($sMethod, 'workflow');`
`95`	`99`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ public function process(ContainerBuilder $container): void`
`31`	`31`	`->setArguments([`
`32`	`32`	`new Reference("debug.{$id}.inner"),`
`33`	`33`	`new Reference('debug.stopwatch'),`
	`34`	`+ new Reference('profiler.is_disabled_state_checker', ContainerBuilder::IGNORE_ON_INVALID_REFERENCE),`
`34`	`35`	`]);`
`35`	`36`	`}`
`36`	`37`	`}`