chore(qa): improve error checking

tucksaun · tucksaun · commit 19f036ead645 · 2025-05-16T15:02:20.000+02:00
diff --git a/.golangci.yml b/.golangci.yml
@@ -27,6 +27,20 @@ linters:
           - github.com/symfony-cli/terminal.Eprintln
           - github.com/symfony-cli/terminal.Eprintfln
           - github.com/symfony-cli/terminal.Eprint
+          - github.com/symfony-cli/terminal.SetLogLevel
           - fmt.Fprintln
           - fmt.Fprintf
           - fmt.Fprint
+  exclusions:
+    presets:
+      - std-error-handling
+      - common-false-positives
+    rules:
+      - path: _test\.go
+        linters:
+          - errcheck
+        text: "(?i)Error return value of .(os\\.(Chdir|Rename)|io\\.Copy). is not checked"
+      - path: _test\.go
+        linters:
+          - errcheck
+        text: "(?i)Error return value of .flags\\.Set. is not checked"
diff --git a/local/php/executor_test.go b/local/php/executor_test.go
@@ -59,8 +59,9 @@ func testStdoutCapture(c *C, dst io.Writer) func() {
 
 	return func() {
 		// Close the writer end of the pipe
-		w.Sync()
-		w.Close()
+		if err := w.Close(); err != nil {
+			c.Errorf("err: %s", err)
+		}
 
 		// Reset stdout
 		os.Stdout = old
@@ -213,7 +214,11 @@ func (s *ExecutorSuite) TestEnvInjection(c *C) {
 	os.Chdir(filepath.Join(home, "project"))
 
 	os.Rename("git", ".git")
-	defer os.Rename(".git", "git")
+	defer func() {
+		// handling error is not really worth it here: we could not really recover it anyway and the original directory
+		// is commited
+		_ = os.Rename(".git", "git")
+	}()
 	defer cleanupExecutorTempFiles()
 
 	var output bytes.Buffer
@@ -232,8 +237,12 @@ func (s *ExecutorSuite) TestEnvInjection(c *C) {
 	projectFile := filepath.Join(".platform", "local", "project.yaml")
 	contents, err := os.ReadFile(projectFile)
 	c.Assert(err, IsNil)
-	defer os.WriteFile(projectFile, contents, 0644)
-	os.WriteFile(projectFile, bytes.Replace(contents, []byte("bew7pfa7t2ut2"), []byte("aew7pfa7t2ut2"), 1), 0644)
+	defer func() {
+		// handling error is not really worth it here: we could not really recover it and anyway the original file
+		// content is commited
+		_ = os.WriteFile(projectFile, contents, 0644)
+	}()
+	c.Assert(os.WriteFile(projectFile, bytes.Replace(contents, []byte("bew7pfa7t2ut2"), []byte("aew7pfa7t2ut2"), 1), 0644), IsNil)
 
 	output.Reset()
 	outCloser = testStdoutCapture(c, &output)
diff --git a/local/proxy/proxy_test.go b/local/proxy/proxy_test.go
@@ -59,7 +59,7 @@ func (s *ProxySuite) TestProxy(c *C) {
 		TLD:  "wip",
 		path: "testdata/.symfony5/proxy.json",
 	}, ca, log.New(zerolog.New(os.Stderr), "", 0), true)
-	os.MkdirAll("testdata/.symfony5", 0755)
+	c.Assert(os.MkdirAll("testdata/.symfony5", 0755), IsNil)
 	err = p.Save()
 	c.Assert(err, IsNil)
 
@@ -172,15 +172,16 @@ func (s *ProxySuite) TestProxy(c *C) {
 	{
 		backend := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 			w.WriteHeader(200)
-			w.Write([]byte(`http://symfony-no-tls.wip`))
+			_, err := w.Write([]byte(`http://symfony-no-tls.wip`))
+			c.Assert(err, IsNil)
 		}))
 		defer backend.Close()
 		backendURL, err := url.Parse(backend.URL)
 		c.Assert(err, IsNil)
 
 		p := pid.New("symfony_com_no_tls", nil)
 		port, _ := strconv.Atoi(backendURL.Port())
-		p.Write(os.Getpid(), port, "http")
+		c.Assert(p.Write(os.Getpid(), port, "http"), IsNil)
 
 		req, _ := http.NewRequest("GET", "http://symfony-no-tls.wip/", nil)
 		req.Close = true
