feat(http): add flag/config to allow CORS requests, close #229

Kocal · tucksaun · commit 577e09714b23 · 2024-12-09T12:50:48.000+01:00
diff --git a/commands/local_server_start.go b/commands/local_server_start.go
@@ -52,6 +52,7 @@ import (
 
 var localWebServerProdWarningMsg = "The local web server is optimized for local development and MUST never be used in a production setup."
 var localWebServerTlsKeyLogWarningMsg = "Logging TLS master key is enabled. It means TLS connections between the client and this server will be INSECURE. This is NOT recommended unless you are debugging the connections."
+var localWebServerAllowsCORSLogWarningMsg = "Cross-origin resource sharing (CORS) is enabled for all requests.\nYou may want to use https://github.com/nelmio/NelmioCorsBundle to have better control over HTTP headers."
 
 var localServerStartCmd = &console.Command{
 	Category:    "local",
@@ -83,6 +84,7 @@ var localServerStartCmd = &console.Command{
 			EnvVars: []string{"SSLKEYLOGFILE"},
 		},
 		&console.BoolFlag{Name: "no-workers", Usage: "Do not start workers"},
+		&console.BoolFlag{Name: "allow-cors", Usage: "Allow Cross-origin resource sharing (CORS) requests"},
 	},
 	Action: func(c *console.Context) error {
 		ui := terminal.SymfonyStyle(terminal.Stdout, terminal.Stdin)
@@ -188,6 +190,10 @@ var localServerStartCmd = &console.Command{
 			ui.Warning(localWebServerTlsKeyLogWarningMsg)
 		}
 
+		if config.AllowCORS {
+			ui.Warning(localWebServerAllowsCORSLogWarningMsg)
+		}
+
 		lw, err := pidFile.LogWriter()
 		if err != nil {
 			return err
diff --git a/local/http/cors.go b/local/http/cors.go
@@ -0,0 +1,34 @@
+/*
+ * Copyright (c) 2021-present Fabien Potencier <fabien@symfony.com>
+ *
+ * This file is part of Symfony CLI project
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package http
+
+import (
+	"net/http"
+)
+
+func corsWrapper(h http.Handler) http.Handler {
+	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.Header().Set("Access-Control-Allow-Origin", "*")
+		w.Header().Set("Access-Control-Allow-Methods", "*")
+		w.Header().Set("Access-Control-Allow-Headers", "*")
+
+		h.ServeHTTP(w, r)
+	})
+}
diff --git a/local/http/http.go b/local/http/http.go
@@ -56,6 +56,7 @@ type Server struct {
 	Appversion    string
 	UseGzip       bool
 	TlsKeyLogFile string
+	AllowCORS     bool
 
 	httpserver  *http.Server
 	httpsserver *http.Server
@@ -98,6 +99,10 @@ func (s *Server) Start(errChan chan error) (int, error) {
 		proxyHandler = gzipWrapper(proxyHandler)
 	}
 
+	if s.AllowCORS {
+		proxyHandler = corsWrapper(proxyHandler)
+	}
+
 	s.httpserver = &http.Server{
 		Handler: proxyHandler,
 	}
diff --git a/local/project/config.go b/local/project/config.go
@@ -49,6 +49,7 @@ type Config struct {
 	UseGzip       bool   `yaml:"use_gzip"`
 	TlsKeyLogFile string `yaml:"tls_key_log_file"`
 	NoWorkers     bool   `yaml:"no_workers"`
+	AllowCORS     bool   `yaml:"allow_cors"`
 }
 
 type FileConfig struct {
@@ -122,6 +123,9 @@ func NewConfigFromContext(c *console.Context, projectDir string) (*Config, *File
 	if c.IsSet("no-workers") {
 		config.NoWorkers = c.Bool("no-workers")
 	}
+	if c.IsSet("allow-cors") {
+		config.AllowCORS = c.Bool("allow-cors")
+	}
 
 	return config, fileConfig, nil
 }
diff --git a/local/project/project.go b/local/project/project.go
@@ -63,6 +63,7 @@ func New(c *Config) (*Project, error) {
 			UseGzip:       c.UseGzip,
 			Appversion:    c.AppVersion,
 			TlsKeyLogFile: c.TlsKeyLogFile,
+			AllowCORS:     c.AllowCORS,
 		},
 	}
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ type Config struct {`
`49`	`49`	UseGzip bool `yaml:"use_gzip"`
`50`	`50`	TlsKeyLogFile string `yaml:"tls_key_log_file"`
`51`	`51`	NoWorkers bool `yaml:"no_workers"`
	`52`	+ AllowCORS bool `yaml:"allow_cors"`
`52`	`53`	`}`
`53`	`54`
`54`	`55`	`type FileConfig struct {`
`@@ -122,6 +123,9 @@ func NewConfigFromContext(c console.Context, projectDir string) (Config, *File`
`122`	`123`	`if c.IsSet("no-workers") {`
`123`	`124`	`config.NoWorkers = c.Bool("no-workers")`
`124`	`125`	`}`
	`126`	`+ if c.IsSet("allow-cors") {`
	`127`	`+ config.AllowCORS = c.Bool("allow-cors")`
	`128`	`+ }`
`125`	`129`
`126`	`130`	`return config, fileConfig, nil`
`127`	`131`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ func New(c Config) (Project, error) {`
`63`	`63`	`UseGzip: c.UseGzip,`
`64`	`64`	`Appversion: c.AppVersion,`
`65`	`65`	`TlsKeyLogFile: c.TlsKeyLogFile,`
	`66`	`+ AllowCORS: c.AllowCORS,`
`66`	`67`	`},`
`67`	`68`	`}`
`68`	`69`	`if err != nil {`