From 78d8604c8928e9f955f17e662833a59877560ca0 Mon Sep 17 00:00:00 2001 From: Lox Date: Mon, 21 Jul 2025 12:26:35 +0200 Subject: [PATCH] fix[Windows]: Close log writer before removing files to avoid locked log on shutdown On Windows, deleting an open log file fails because it's still held by the process. This commit updates PidFile.Remove() to explicitly close the log writer if open Fixes #631 --- local/pid/pidfile.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/local/pid/pidfile.go b/local/pid/pidfile.go index b044c8a0..54dbd86d 100644 --- a/local/pid/pidfile.go +++ b/local/pid/pidfile.go @@ -305,6 +305,11 @@ func AllWorkers(dir string) []*PidFile { // Remove a pidfile func (p *PidFile) Remove() error { for _, file := range []string{p.LogFile(), p.PidFile()} { + // Ensure log writer is closed first to avoid "file is being used" on Windows + if p.lw != nil { + _ = p.lw.Close() + p.lw = nil + } if err := os.Remove(file); err != nil && !os.IsNotExist(err) { return errors.WithStack(err) } pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy