test: add Validator tests for coverage

awwright · awwright · commit abfea4b9f1f6 · 2020-10-19T18:20:24.000-07:00
diff --git a/lib/validator.js b/lib/validator.js
@@ -56,6 +56,7 @@ Validator.prototype.addSchema = function addSchema (schema, base) {
   for(var uri in scan.ref){
     this.unresolvedRefs.push(uri);
   }
+  // Remove newly defined schemas from unresolvedRefs
   this.unresolvedRefs = this.unresolvedRefs.filter(function(uri){
     return typeof self.schemas[uri]==='undefined';
   });
diff --git a/test/Validator.test.js b/test/Validator.test.js
@@ -12,6 +12,102 @@ describe('Validator', function () {
   beforeEach(function () {
     validator = new Validator();
   });
+  describe('Validator#unresolvedRefs', function(){
+    it('initial value', function(){
+      assert.deepStrictEqual(validator.unresolvedRefs, []);
+    });
+    it('addSchema', function(){
+      validator.addSchema({
+        id: 'http://example.com/base.json',
+        items: {
+          $ref: 'item.json',
+        },
+      });
+      assert.deepStrictEqual(validator.unresolvedRefs, ['http://example.com/item.json']);
+    });
+  });
+  describe('Validator#addSchema', function () {
+    it('argument schema must be a schema: object', function(){
+      validator.addSchema({}, 'http://example.com/base.json');
+      assert.deepStrictEqual(validator.schemas['http://example.com/base.json'], {});
+    });
+    // TODO: held for major version upgrade
+    it.skip('argument schema must be a schema: true', function(){
+      validator.addSchema(true, 'http://example.com/base.json');
+      assert.deepStrictEqual(validator.schemas['http://example.com/base.json'], true);
+    });
+    // TODO: held for major version upgrade
+    it.skip('argument schema must be a schema: false', function(){
+      validator.addSchema(false, 'http://example.com/base.json');
+      assert.deepStrictEqual(validator.schemas['http://example.com/base.json'], false);
+    });
+    it('argument schema must be a schema: null', function(){
+      var res = validator.addSchema(undefined, 'http://example.com/base.json');
+      assert.strictEqual(res, null);
+      assert(!('http://example.com/base.json' in validator.schemas));
+    });
+    it('argument schema must be a schema: undefined', function(){
+      var res = validator.addSchema(undefined, 'http://example.com/base.json');
+      assert.strictEqual(res, null);
+      assert(!('http://example.com/base.json' in validator.schemas));
+    });
+    // TODO: held for major version upgrade
+    it.skip('argument schema must not be a number', function(){
+      assert.throws(function(){
+        validator.addSchema(1, 'http://example.com/base.json');
+      }, function(err){
+        assert(err instanceof Error);
+        return true;
+      });
+    });
+    // TODO: held for major version upgrade
+    it.skip('argument schema must not be a string', function(){
+      assert.throws(function(){
+        validator.addSchema("schema", 'http://example.com/base.json');
+      }, function(err){
+        assert(err instanceof Error);
+        return true;
+      });
+    });
+    // TODO: held for major version upgrade
+    it.skip('argument schema must not be null', function(){
+      assert.throws(function(){
+        validator.addSchema(null, 'http://example.com/base.json');
+      }, function(err){
+        assert(err instanceof Error);
+        return true;
+      });
+    });
+    // TODO: held for major version upgrade
+    it.skip('argument schema must not be undefined', function(){
+      assert.throws(function(){
+        validator.addSchema(undefined, 'http://example.com/base.json');
+      }, function(err){
+        assert(err instanceof Error);
+        return true;
+      });
+    });
+    it('addSchema(schema) with absolute id', function(){
+      validator.addSchema({
+        id: 'http://example.com/base.json',
+      });
+      assert.deepStrictEqual(validator.unresolvedRefs, []);
+    });
+    it('addSchema(schema) with absolute $id', function(){
+      validator.addSchema({
+        $id: 'http://example.com/base.json',
+      });
+      assert.deepStrictEqual(validator.unresolvedRefs, []);
+    });
+    it('addSchema(schema, base) with relative id', function(){
+      validator.addSchema({id: 'base.json'}, 'http://example.com/index.html');
+      assert('http://example.com/base.json' in validator.schemas);
+    });
+    it('addSchema(schema, base) with relative $id', function(){
+      validator.addSchema({$id: 'base.json'}, 'http://example.com/index.html');
+      assert('http://example.com/base.json' in validator.schemas);
+    });
+  });
   describe('Validator#validate', function () {
     it('schema may be an object', function () {
       var res = validator.validate(true, {});
@@ -33,6 +129,14 @@ describe('Validator', function () {
         return true;
       });
     });
+    it('schema cannot be undefined', function () {
+      assert.throws(function () {
+        validator.validate(true, undefined);
+      }, function(err){
+        assert(err instanceof SchemaError);
+        return true;
+      });
+    });
     it('schema cannot be a string', function () {
       assert.throws(function () {
         validator.validate(true, "string");
@@ -41,5 +145,14 @@ describe('Validator', function () {
         return true;
       });
     });
+    it('options may be undefined', function () {
+      validator.validate(null, true, undefined);
+    });
+    it('options may be null', function () {
+      validator.validate(null, true, null);
+    });
+    it('options.base must be a string', function () {
+      validator.validate(null, true, null);
+    });
   });
 });

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ Validator.prototype.addSchema = function addSchema (schema, base) {`
`56`	`56`	`for(var uri in scan.ref){`
`57`	`57`	`this.unresolvedRefs.push(uri);`
`58`	`58`	`}`
	`59`	`+ // Remove newly defined schemas from unresolvedRefs`
`59`	`60`	`this.unresolvedRefs = this.unresolvedRefs.filter(function(uri){`
`60`	`61`	`return typeof self.schemas[uri]==='undefined';`
`61`	`62`	`});`