[ #HLODiff ]Fix a bug in hlo_diff_summary.cc

tensorflower-gardener · tensorflower-gardener · commit 2b1533e83140 · 2025-07-22T13:31:05.000-07:00
The line to log the right computations was incorrectly placing them at the same index as the left computations, which caused the string to overwrite itself, leaving only one of the computations to be printed.

PiperOrigin-RevId: 785915761
diff --git a/third_party/xla/xla/hlo/tools/hlo_diff/hlo_diff_summary.cc b/third_party/xla/xla/hlo/tools/hlo_diff/hlo_diff_summary.cc
@@ -311,8 +311,9 @@ void LogComputationGroup(const ComputationGroup& computation_group) {
         "L: %s", computation_group.left_computations[i]->name());
   }
   for (int i = 0; i < computation_group.right_computations.size(); ++i) {
-    computations_str[i] = absl::StrFormat(
-        "R: %s", computation_group.right_computations[i]->name());
+    computations_str[computation_group.left_computations.size() + i] =
+        absl::StrFormat("R: %s",
+                        computation_group.right_computations[i]->name());
   }
   LOG(INFO) << absl::StrJoin(computations_str, ", ");
 }

Original file line number	Diff line number	Diff line change
`@@ -311,8 +311,9 @@ void LogComputationGroup(const ComputationGroup& computation_group) {`
`311`	`311`	`"L: %s", computation_group.left_computations[i]->name());`
`312`	`312`	`}`
`313`	`313`	`for (int i = 0; i < computation_group.right_computations.size(); ++i) {`
`314`		`- computations_str[i] = absl::StrFormat(`
`315`		`- "R: %s", computation_group.right_computations[i]->name());`
	`314`	`+ computations_str[computation_group.left_computations.size() + i] =`
	`315`	`+ absl::StrFormat("R: %s",`
	`316`	`+ computation_group.right_computations[i]->name());`
`316`	`317`	`}`
`317`	`318`	`LOG(INFO) << absl::StrJoin(computations_str, ", ");`
`318`	`319`	`}`