Fix buffer overflow bug in HloLexer::LexInt64Impl and add regression tests.
#94982
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
800df52 to
cf47a4b
Compare
…n tests. It is possible to have a buffer with last character being a digit character instead of a NULL character. For that scenario, current implementation fails by calling `*pos` even after reaching the end. The `pos < end` check takes care of it. PiperOrigin-RevId: 768268179
cf47a4b to
1edb77a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix buffer overflow bug in
HloLexer::LexInt64Impland add regression tests.It is possible to have a buffer with last character being a digit character instead of a NULL character. For that scenario, current implementation fails by calling
*poseven after reaching the end. Thepos < endcheck takes care of it.