[XLA:GPU] NFC move fusion block level rewriter logic to the pass #97515
+124
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abacdfd to
7695ab1
Compare
I am preparing for an incoming change and keeping the logic of the pass in the pipeline makes everything quite convoluted. Also the matching logic is completely untested. We already have a debug option to blank allow all rewrites - that what fusion_block_level_rewriter test currently wants. PiperOrigin-RevId: 787018441
7695ab1 to
5e1bf9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:GPU] NFC move fusion block level rewriter logic to the pass
I am preparing for an incoming change and keeping the logic of the pass in the pipeline makes everything quite convoluted. Also the matching logic is completely untested. We already have a debug option to blank allow all rewrites - that what fusion_block_level_rewriter test currently wants.