fixing PHPStan errors + PHPCodeSniffer

Julien Neuhart · Julien Neuhart · commit fcb6fda2569a · 2018-12-03T16:24:20.000+01:00
diff --git a/app/src/Controller/ApiPostController.php b/app/src/Controller/ApiPostController.php
@@ -60,4 +60,4 @@ public function getAllActions(): JsonResponse
 
         return new JsonResponse($data, 200, [], true);
     }
-}
+}
diff --git a/app/src/Controller/ApiSecurityController.php b/app/src/Controller/ApiSecurityController.php
@@ -30,4 +30,4 @@ public function logoutAction(): void
     {
         throw new \RuntimeException('This should not be reached!');
     }
-}
+}
diff --git a/app/src/Controller/IndexController.php b/app/src/Controller/IndexController.php
@@ -21,8 +21,8 @@ public function indexAction(): Response
         /** @var User $user */
         $user = $this->getUser();
         return $this->render('base.html.twig', [
-            'isAuthenticated' => json_encode(!\is_null($user)),
-            'roles' => json_encode(!\is_null($user) ? $user->getRoles() : []),
+            'isAuthenticated' => json_encode(!empty($user)),
+            'roles' => json_encode(!empty($user) ? $user->getRoles() : []),
         ]);
     }
-}
+}
diff --git a/app/src/DataFixtures/UserFixtures.php b/app/src/DataFixtures/UserFixtures.php
@@ -21,4 +21,4 @@ public function load(ObjectManager $manager): void
         $manager->persist($userEntity);
         $manager->flush();
     }
-}
+}
diff --git a/app/src/Entity/Post.php b/app/src/Entity/Post.php
@@ -96,4 +96,4 @@ public function getUpdated(): ?\DateTime
     {
         return $this->updated;
     }
-}
+}
diff --git a/app/src/Entity/User.php b/app/src/Entity/User.php
@@ -205,4 +205,4 @@ public function getUpdated(): ?\DateTime
     {
         return $this->updated;
     }
-}
+}
diff --git a/app/src/Security/AuthenticationEntryPoint.php b/app/src/Security/AuthenticationEntryPoint.php
@@ -33,4 +33,4 @@ public function start(Request $request, AuthenticationException $authException =
     {
         return new JsonResponse([], Response::HTTP_FORBIDDEN);
     }
-}
+}
diff --git a/app/src/Security/HashPasswordListener.php b/app/src/Security/HashPasswordListener.php
@@ -78,4 +78,4 @@ private function encodePassword(User $entity): void
 
         $entity->setPassword($encoded);
     }
-}
+}
diff --git a/app/src/Service/PostService.php b/app/src/Service/PostService.php
@@ -40,4 +40,4 @@ public function getAll(): array
     {
         return $this->em->getRepository(Post::class)->findBy([], ['id' => 'DESC']);
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -60,4 +60,4 @@ public function getAllActions(): JsonResponse`
`60`	`60`
`61`	`61`	`return new JsonResponse($data, 200, [], true);`
`62`	`62`	`}`
`63`		`-}`
	`63`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -30,4 +30,4 @@ public function logoutAction(): void`
`30`	`30`	`{`
`31`	`31`	`throw new \RuntimeException('This should not be reached!');`
`32`	`32`	`}`
`33`		`-}`
	`33`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -21,4 +21,4 @@ public function load(ObjectManager $manager): void`
`21`	`21`	`$manager->persist($userEntity);`
`22`	`22`	`$manager->flush();`
`23`	`23`	`}`
`24`		`-}`
	`24`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -96,4 +96,4 @@ public function getUpdated(): ?\DateTime`
`96`	`96`	`{`
`97`	`97`	`return $this->updated;`
`98`	`98`	`}`
`99`		`-}`
	`99`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -205,4 +205,4 @@ public function getUpdated(): ?\DateTime`
`205`	`205`	`{`
`206`	`206`	`return $this->updated;`
`207`	`207`	`}`
`208`		`-}`
	`208`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -33,4 +33,4 @@ public function start(Request $request, AuthenticationException $authException =`
`33`	`33`	`{`
`34`	`34`	`return new JsonResponse([], Response::HTTP_FORBIDDEN);`
`35`	`35`	`}`
`36`		`-}`
	`36`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -78,4 +78,4 @@ private function encodePassword(User $entity): void`
`78`	`78`
`79`	`79`	`$entity->setPassword($encoded);`
`80`	`80`	`}`
`81`		`-}`
	`81`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -40,4 +40,4 @@ public function getAll(): array`
`40`	`40`	`{`
`41`	`41`	`return $this->em->getRepository(Post::class)->findBy([], ['id' => 'DESC']);`
`42`	`42`	`}`
`43`		`-}`
	`43`	`+}`