connection upgrade: do not emit 200 header when establishing conn

rofl0r · rofl0r · commit 991e47d8ebd4 · 2022-05-02T14:22:03.000Z
a tri-state connect_method enum was introduced for this purpose.
if connect_method is set to CM_UPGRADE, the
"HTTP/1.0 200 Connection established" response won't be emitted.
diff --git a/src/conns.h b/src/conns.h
@@ -24,6 +24,12 @@
 #include "main.h"
 #include "hsearch.h"
 
+enum connect_method_e {
+        CM_FALSE = 0,
+        CM_TRUE = 1,
+        CM_UPGRADE = 2,
+};
+
 /*
  * Connection Definition
  */
@@ -37,8 +43,9 @@ struct conn_s {
         /* The request line (first line) from the client */
         char *request_line;
 
+        enum connect_method_e connect_method;
+
         /* Booleans */
-        unsigned int connect_method;
         unsigned int show_stats;
 
         /*
diff --git a/src/reqs.c b/src/reqs.c
@@ -454,7 +454,7 @@ static struct request_s *process_request (struct conn_s *connptr,
                         goto fail;
                 }
 
-                connptr->connect_method = TRUE;
+                connptr->connect_method = CM_TRUE;
         } else {
 #ifdef TRANSPARENT_PROXY
                 if (!do_transparent_proxy
@@ -1756,7 +1756,7 @@ void handle_connection (struct conn_s *connptr, union sockaddr_union* addr)
                              connptr->server_fd);
 
                 if(orderedmap_find (hashofheaders, "upgrade")) {
-                        connptr->connect_method = TRUE;
+                        connptr->connect_method = CM_UPGRADE;
                         safe_write (connptr->server_fd, lines, lines_len);
                 }
 
@@ -1786,6 +1786,8 @@ void handle_connection (struct conn_s *connptr, union sockaddr_union* addr)
 
                         HC_FAIL();
                 }
+        } else if (connptr->connect_method == CM_UPGRADE) {
+                /* NOP */ ;
         } else {
                 if (send_ssl_response (connptr) < 0) {
                         log_message (LOG_ERR,
