chore: print pretty exception after playwright.stop() (microsoft#1899)

mxschmitt · web-flow · commit 19cf427d68a7 · 2023-05-04T23:13:57.000+02:00
diff --git a/playwright/_impl/_sync_base.py b/playwright/_impl/_sync_base.py
@@ -32,6 +32,7 @@
 
 import greenlet
 
+from playwright._impl._helper import Error
 from playwright._impl._impl_to_api_mapping import ImplToApiMapping, ImplWrapper
 
 mapping = ImplToApiMapping()
@@ -92,6 +93,10 @@ def _sync(
         coro: Union[Coroutine[Any, Any, Any], Generator[Any, Any, Any]],
     ) -> Any:
         __tracebackhide__ = True
+        if self._loop.is_closed():
+            coro.close()
+            raise Error("Event loop is closed! Is Playwright already stopped?")
+
         g_self = greenlet.getcurrent()
         task: asyncio.tasks.Task[Any] = self._loop.create_task(coro)
         setattr(task, "__pw_stack__", inspect.stack())
diff --git a/tests/sync/test_sync.py b/tests/sync/test_sync.py
@@ -14,6 +14,7 @@
 
 import multiprocessing
 import os
+from typing import Any, Dict
 
 import pytest
 
@@ -304,3 +305,31 @@ def test_sync_playwright_stop_multiple_times() -> None:
     p.start()
     p.join()
     assert p.exitcode == 0
+
+
+def _test_call_sync_method_after_playwright_close_with_own_loop(
+    browser_name: str,
+    launch_arguments: Dict[str, Any],
+    empty_page: str,
+) -> None:
+    playwright = sync_playwright().start()
+    browser = playwright[browser_name].launch(**launch_arguments)
+    context = browser.new_context()
+    page = context.new_page()
+    page.goto(empty_page)
+    playwright.stop()
+    with pytest.raises(Error) as exc:
+        page.evaluate("1+1")
+    assert "Event loop is closed! Is Playwright already stopped?" in str(exc.value)
+
+
+def test_call_sync_method_after_playwright_close_with_own_loop(
+    server: Server, browser_name: str, launch_arguments: Dict[str, Any]
+) -> None:
+    p = multiprocessing.Process(
+        target=_test_call_sync_method_after_playwright_close_with_own_loop,
+        args=[browser_name, launch_arguments, server.EMPTY_PAGE],
+    )
+    p.start()
+    p.join()
+    assert p.exitcode == 0
