From 424dd47f155cde4be8658cebdc282685fb4b5f04 Mon Sep 17 00:00:00 2001 From: tormol Date: Tue, 14 Jun 2022 00:37:17 +0200 Subject: [PATCH] Replace AsciiChar::SOX with associated constant STX SOX is the wrong name for this character. Renaming the variant and adding SOX as associated constant would break `use`s of it. both explicit and glob imports. Fixes #78. --- src/ascii_char.rs | 14 ++++++++++++-- tests.rs | 7 +++++++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/src/ascii_char.rs b/src/ascii_char.rs index 5011949..f18dfd9 100644 --- a/src/ascii_char.rs +++ b/src/ascii_char.rs @@ -13,7 +13,10 @@ pub enum AsciiChar { Null = 0, /// [Start Of Heading](http://en.wikipedia.org/wiki/Start_of_Heading) SOH = 1, - /// [Start Of teXt](http://en.wikipedia.org/wiki/Start_of_Text) + #[allow(clippy::doc_markdown)] + /// [Start of TeXt](http://en.wikipedia.org/wiki/Start_of_Text) + #[doc(hidden)] + #[deprecated(since="1.2.0", note="Replaced with AsciiChar::STX which is the correct name for this variant.")] SOX = 2, /// [End of TeXt](http://en.wikipedia.org/wiki/End-of-Text_character) ETX = 3, @@ -278,6 +281,13 @@ pub enum AsciiChar { } impl AsciiChar { + /// [Start of TeXt](http://en.wikipedia.org/wiki/Start_of_Text) + /// + /// (It's an associated constant instead of a variant because + /// the variant for it has an incorrect name.) + #[allow(deprecated, clippy::doc_markdown)] + pub const STX: AsciiChar = AsciiChar::SOX; + /// Constructs an ASCII character from a `u8`, `char` or other character type. /// /// # Errors @@ -337,7 +347,7 @@ impl AsciiChar { #[rustfmt::skip] const ALL: [AsciiChar; 128] = [ - Null, SOH, SOX, ETX, EOT, ENQ, ACK, Bell, + Null, SOH, AsciiChar::STX, ETX, EOT, ENQ, ACK, Bell, BackSpace, Tab, LineFeed, VT, FF, CarriageReturn, SI, SO, DLE, DC1, DC2, DC3, DC4, NAK, SYN, ETB, CAN, EM, SUB, ESC, FS, GS, RS, US, diff --git a/tests.rs b/tests.rs index 017a7be..b84e59c 100644 --- a/tests.rs +++ b/tests.rs @@ -27,6 +27,13 @@ fn to_ascii() { assert_eq!("( ;".as_ascii_str(), Ok(a)); } +#[test] +fn deprecated_variant() { + #![allow(deprecated)] + use AsciiChar::*; + assert_eq!(AsciiChar::STX, SOX); +} + #[test] #[cfg(feature = "std")] fn into_ascii() { pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy