Improve test coverage on chunked_json

areski · areski · commit 549d13eb54fc · 2015-03-09T13:58:21.000+01:00
diff --git a/test-requirements.txt b/test-requirements.txt
@@ -1,3 +1,4 @@
 nose
+nose-cov
 mock
-requests-mock
+requests-mock
diff --git a/tests/influxdb/chunked_json_test.py b/tests/influxdb/chunked_json_test.py
@@ -0,0 +1,36 @@
+# -*- coding: utf-8 -*-
+
+import unittest
+
+from influxdb import chunked_json
+
+
+class TestChunkJson(unittest.TestCase):
+
+    @classmethod
+    def setUpClass(cls):
+        super(TestChunkJson, cls).setUpClass()
+
+    def test_load(self):
+        """
+        Tests reading a sequence of JSON values from a string
+        """
+        example_response = \
+            '{"results": [{"series": [{"name": "sdfsdfsdf", ' \
+            '"columns": ["time", "value"], "values": ' \
+            '[["2009-11-10T23:00:00Z", 0.64]]}]}, {"series": ' \
+            '[{"name": "cpu_load_short", "columns": ["time", "value"], ' \
+            '"values": [["2009-11-10T23:00:00Z", 0.64]]}]}]}'
+
+        res = list(chunked_json.loads(example_response))
+        # import ipdb; ipdb.set_trace()
+
+        # self.assertTrue(res)
+        self.assertListEqual(
+            [
+                {
+                    'results': [{'series': [{'values': [['2009-11-10T23:00:00Z', 0.64]], 'name': 'sdfsdfsdf', 'columns': ['time', 'value']}]}, {'series': [{'values': [['2009-11-10T23:00:00Z', 0.64]], 'name': 'cpu_load_short', 'columns': ['time', 'value']}]}]
+                }
+            ],
+            res
+        )
diff --git a/tests/influxdb/client_test.py b/tests/influxdb/client_test.py
@@ -74,7 +74,7 @@ def setUp(self):
                     "region": "us-west"
                 },
                 "timestamp": "2009-11-10T23:00:00Z",
-                "values": {
+                "fields": {
                     "value": 0.64
                 }
             }
@@ -114,7 +114,7 @@ def test_write(self):
                              "tags": {"host": "server01",
                                       "region": "us-west"},
                              "timestamp": "2009-11-10T23:00:00Z",
-                             "values": {"value": 0.64}}]}
+                             "fields": {"value": 0.64}}]}
             )
 
             self.assertEqual(
@@ -125,7 +125,7 @@ def test_write(self):
                              "tags": {"host": "server01",
                                       "region": "us-west"},
                              "timestamp": "2009-11-10T23:00:00Z",
-                             "values": {"value": 0.64}}]}
+                             "fields": {"value": 0.64}}]}
             )
 
     def test_write_points(self):

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ def setUp(self):`
`74`	`74`	`"region": "us-west"`
`75`	`75`	`},`
`76`	`76`	`"timestamp": "2009-11-10T23:00:00Z",`
`77`		`- "values": {`
	`77`	`+ "fields": {`
`78`	`78`	`"value": 0.64`
`79`	`79`	`}`
`80`	`80`	`}`
`@@ -114,7 +114,7 @@ def test_write(self):`
`114`	`114`	`"tags": {"host": "server01",`
`115`	`115`	`"region": "us-west"},`
`116`	`116`	`"timestamp": "2009-11-10T23:00:00Z",`
`117`		`- "values": {"value": 0.64}}]}`
	`117`	`+ "fields": {"value": 0.64}}]}`
`118`	`118`	`)`
`119`	`119`
`120`	`120`	`self.assertEqual(`
`@@ -125,7 +125,7 @@ def test_write(self):`
`125`	`125`	`"tags": {"host": "server01",`
`126`	`126`	`"region": "us-west"},`
`127`	`127`	`"timestamp": "2009-11-10T23:00:00Z",`
`128`		`- "values": {"value": 0.64}}]}`
	`128`	`+ "fields": {"value": 0.64}}]}`
`129`	`129`	`)`
`130`	`130`
`131`	`131`	`def test_write_points(self):`