Skip to content

Bug: await-thenable doesn't handle unions cleanly in for-await [8.8.0 regression] #10080

@JavaScriptBach

Description

@JavaScriptBach

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.4.3&showAST=es&fileType=.tsx&code=MYewdgzgLgBAhhAnmYBJKBTATgLhgQSRXWzgCMAbDAHmiwEswBzAPhgB8YStyraoGzNgF4YAbQC6AbgBQAMxBZ4Adzj1YAClCRYEGCDnwiaTFgCUMAN4wAvjIwAPAA6LY1m0A&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6AQwHd3K78ALRE3YAjJOiiJo0APbRI4MAF8QSoA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

const asyncIter: AsyncIterable<string> | Iterable<string> = [];

for await (const s of asyncIter) { }

export { }

ESLint Config

See playground

tsconfig

{
  "compilerOptions": {
    // ...
  }
}

Expected Result

If I call for await on an iterator that is typed as AsyncIterable<string> | Iterable<string>, I expect one of the following to happen:

  1. No lint error, because the code is arguably correct (for await works on both sync and async iterables)
  2. Lint error but no autofix, because the code is arguably ugly (taking a union of sync and async iterables leads to unnecessary promises being created, which is the whole point of this rule), but it's not safe to remove the await because that would introduce a code bug.

Actual Result

Lint error, with an unsafe autofix suggesting to remove the await.

Additional Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy