-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Repro
{
"rules": {
"@typescript-eslint/prefer-readonly": 2
}
}
// your repro code case
class X {
private _isValid? = true;
get isValid(): boolean {
return this._isValid;
}
constructor(data?: {}) {
if (!data) {
this._isValid = false;
}
}
}
Expected Result
No report
Actual Result
@typescript-eslint/prefer-readonly
Member '_isValid' is never reassigned; mark it as `readonly`
Versions
package | version |
---|---|
@typescript-eslint/eslint-plugin |
2.3.3 |
@typescript-eslint/parser |
2.3.3 |
TypeScript |
3.6.3 |
ESLint |
6.5.1 |
node |
12.11.1 |
yarn |
1.19.0 |
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin