Skip to content

fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType #11432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType #11432

wants to merge 2 commits into from
+58 −0

Conversation

mdm317
Copy link
Contributor

@mdm317 mdm317 commented Jul 29, 2025

PR Checklist

Overview

Don't report an error when returning a union type that includes a classType.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 29, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 602a349
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6888e6daef4ef500083b435a
😎 Deploy Preview https://deploy-preview-11432--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 29, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 602a349

Command Status Duration Result
nx run integration-tests:test ❌ Failed 54s View ↗
nx run ast-spec:test -- --coverage ❌ Failed 12s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 25s View ↗
nx run-many -t lint ✅ Succeeded 3m 22s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 14s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
Additional runs (15) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-29 15:28:51 UTC

@mdm317 mdm317 changed the title fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType. fix(eslint-plugin): [prefer-return-this-type] don't report an error when returning a union type that includes a classType Jul 29, 2025
@mdm317
Copy link
Contributor Author

mdm317 commented Jul 30, 2025

I think there's an issue with these two CI commands:
nx run ast-spec:test -- --coverage and nx run integration-tests:test

If not, please let me know.

@mdm317 mdm317 marked this pull request as ready for review July 30, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: prefer-return-this-type reports on return type unions containing the class when an actual return value might not be this
1 participant
@mdm317
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy