Incosistent AST for typeArgument and typeParameters

While doing #219 i notice that we have small inconsistency in AST, sometimes we are outputting `TSTypeParameterDeclaration` and `TSTypeParameterInstantiation`  without nodes and sometimes we are omitting this node completely.

https://github.com/typescript-eslint/typescript-eslint/blob/690bff322adbebe181b3efb33c46408e2b819b9d/packages/typescript-estree/src/convert.ts#L1364-L1368

https://github.com/typescript-eslint/typescript-eslint/blob/690bff322adbebe181b3efb33c46408e2b819b9d/packages/typescript-estree/src/convert.ts#L1643-L1647

https://github.com/typescript-eslint/typescript-eslint/blob/690bff322adbebe181b3efb33c46408e2b819b9d/packages/typescript-estree/src/convert.ts#L693-L697

https://github.com/typescript-eslint/typescript-eslint/blob/690bff322adbebe181b3efb33c46408e2b819b9d/packages/typescript-estree/src/convert.ts#L2093-L2097

we should align it, but i'm unsure if we should always have it or not

additionally we should handle #146 in update for it

	if (superClass.types[0] && superClass.types[0].typeArguments) {
	result.superTypeParameters = this.convertTypeArgumentsToTypeParameters(
	superClass.types[0].typeArguments
	);
	}

	if (node.typeArguments && node.typeArguments.length) {
	result.typeParameters = this.convertTypeArgumentsToTypeParameters(
	node.typeArguments
	);
	}

	if (node.typeParameters && node.typeParameters.length) {
	result.typeParameters = this.convertTSTypeParametersToTypeParametersDeclaration(
	node.typeParameters
	);
	}

	if (node.typeParameters) {
	result.typeParameters = this.convertTSTypeParametersToTypeParametersDeclaration(
	node.typeParameters
	);
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Incosistent AST for typeArgument and typeParameters #220

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Uh oh!

Incosistent AST for typeArgument and typeParameters #220

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.