-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
ASTPRs and Issues about the AST structurePRs and Issues about the AST structureaccepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedThis change will require a new major version to be releasedpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estreeIssues related to @typescript-eslint/typescript-estree
Description
THIS IS BREAKING CHANGE
What is this change about?
TSImportType
has boolean property isTypeOf
that is inconsistent with other usages of typeof
within AST structure.
isTypeOf
property is unique (not used anywhere else in code)
type x = typeof import('x')
TSImportType:
- isTypeOf: boolean
type x = typeof window
TSTypeQuery:
- exprName: Identifier
Why we should change it?
- Improve consistency of ast structure.
- Align generated structure with babel representation
- Allow consumers (eg. prettier) to correctly place comment - link
typeof /* comment */ import('x')
sosukesuzuki and ExE-Boss
Metadata
Metadata
Assignees
Labels
ASTPRs and Issues about the AST structurePRs and Issues about the AST structureaccepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedThis change will require a new major version to be releasedpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estreeIssues related to @typescript-eslint/typescript-estree