-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomerspackage: visitor-keysIssues related to @typescript-eslint/visitor-keysIssues related to @typescript-eslint/visitor-keys
Description
I'm sorry for not using any template but none apply.
After filing #4705 I investigated and the reason for the missing parent property is that there missing visitor keys (in the issues case implements
for TSInterfaceDeclaration).
As such ESLint does not traverse the child nodes and therefore does not add the parent property.
I built the ast spec and compared the "enhanced" and TypeScript-only node types and found more missing keys.
The missing keys are:
MethodDefinition: typeParameters
TSInterfaceDeclaration: implements
TSNamedTupleMember: label
TSEnumDeclaration: modifiers
TSModuleDeclaration: modifiers
Versions
package | version |
---|---|
@typescript-eslint/typescript-estree |
5.16.0 |
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomerspackage: visitor-keysIssues related to @typescript-eslint/visitor-keysIssues related to @typescript-eslint/visitor-keys