Skip to content

Bug(website): compiler options are not passed to the lint run #5079

New issue
New issue
Closed
#5080
#5061
Closed
Bug(website): compiler options are not passed to the lint run#5079
#5080
#5061
Labels
accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workingpackage: websiteIssues related to the @typescript-eslint website
@bradzacher

Description

@bradzacher
bradzacher
opened on May 25, 2022

Best shown via a video:
https://user-images.githubusercontent.com/7462525/170336044-461ec681-59ec-4bfe-8800-e992bb1a8674.mov

It looks like the compiler options are always the default options we set here:

typescript-eslint/packages/website/src/components/editor/useSandboxServices.ts

Lines 54 to 60 in 519dd7b

const compilerOptions: Monaco.languages.typescript.CompilerOptions = {
noResolve: true,
target: main.languages.typescript.ScriptTarget.ESNext,
jsx: props.jsx ? main.languages.typescript.JsxEmit.React : undefined,
lib: ['es2021', 'esnext'],
module: main.languages.typescript.ModuleKind.ESNext,
};

Side note: we should add strict: true to the default because it's the best-practice!

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workingpackage: websiteIssues related to the @typescript-eslint website

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy