Skip to content

Repo: ESLint warnings in useSandboxServices (react-hooks/exhaustive-deps) #6917

New issue
New issue
Closed
Closed
Repo: ESLint warnings in useSandboxServices (react-hooks/exhaustive-deps)#6917
Labels
accepting prsGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docs
@JoshuaKGoldberg

Description

@JoshuaKGoldberg
JoshuaKGoldberg
opened on Apr 16, 2023

Suggestion

/home/runner/work/typescript-eslint/typescript-eslint/packages/website/src/components/editor/useSandboxServices.ts
Warning:   128:6  warning  React Hook useEffect has missing dependencies: 'colorMode', 'onLoaded', and 'props'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

Example: #6907 -> https://github.com/typescript-eslint/typescript-eslint/actions/runs/4703925812/jobs/8343076171?pr=6907

This is showing up in PRs. Can we fix for the rule's complaint without causing bugs in the playground?

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy