Skip to content

Rule proposal: forbid unnecessary assignment of parameter properties #7045

@EvgenyOrekhov

Description

@EvgenyOrekhov

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • My proposal specifically checks TypeScript syntax, or it proposes a check that requires type information to be accurate.
  • My proposal is not a "formatting rule"; meaning it does not just enforce how code is formatted (whitespace, brace placement, etc).
  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

My rule would check that there are no unnecessary assignments of parameter properties in constructors.

Fail Cases

class Foo {
  constructor(public bar: string) {
    this.bar = bar; // <-- warn here
  }
}

class Foo2 {
  baz: string;
  constructor(public bar: string, baz: string) {
    this.bar = bar; // <-- warn here
    this.baz = baz;
  }
}

Pass Cases

class Foo {
  constructor(public bar: string) {}
}

class Foo2 {
  baz: string;
  constructor(public bar: string, baz: string) {
    this.baz = baz;
  }
}

Additional Info

You can see in this TypeScript playground that assignment of parameter properties produces duplicate assignment:

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issueenhancement: new plugin ruleNew rule request for eslint-pluginlocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy