Skip to content

Remove parseWithNodeMaps #7119

@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Overview

Copying @fisker's #6760 (comment):

I want give an update here, we (Prettier) can remove all the invalid node checks after upgrade to latest v6, so we can now use parse dirctly instead of parseWithNodeMaps. I think this method was added because Prettier need it at that moment, feel free to remove it if you think it's unnecessary to keep.

We always like deleting unused code! Just checking on Sourcegraph, https://sourcegraph.com/search?q=context:global+parseWithNodeMaps+-repo:.*typescript-eslint.*+-file:.*node_modules.*&patternType=standard&sm=1&groupBy=repo shows exactly one other runtime use: brodybits/prettierxsrc/language-js/parser-typescript.js: a fork of prettier not updated since 2021. cc @brodybits

I think it's safe to remove parseWithNodeMaps. Filing this issue under triage to check with @typescript-eslint/triage-team.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedenhancementNew feature or requestpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estree

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy