Skip to content

Repo: Playground code refactor: Playground.tsx state switches #7630

@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Suggestion

From #6843 (comment), referring to all the logical ternaries in Playground.tsx:

i have a feeling that i should extract this to separate component, this and/or condition chain is getting complex

https://github.com/typescript-eslint/typescript-eslint/pull/6843/files#diff-c76545bc907e11e58eb71533f91f9887abb2a21dc4d8d2a389317dffbbf5a72c

There are indeed a lot of logical conditions in that file. It'd be nice to streamline the logic a bit to be more readable / straightforward / less complex. Maybe a dedicated component or two? Maybe an enum that gets switched on in render logic?

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docswebsite: playground

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy