Skip to content

fix(typescript-estree): infers singleRun as true for project service #11327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

fix(typescript-estree): infers singleRun as true for project service #11327

wants to merge 14 commits into from
+9 −2

Conversation

nayounsang
Copy link
Contributor

PR Checklist

Overview

As project is null when projectService is true, we have to fix validate logic

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 21, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b0dcd4a
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/687a5f2141f6970008f78813
😎 Deploy Preview https://deploy-preview-11327--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 87 (🔴 down 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 21, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b0dcd4a

Command Status Duration Result
nx run-many -t typecheck ❌ Failed 2m 15s View ↗
nx test eslint-plugin-internal --coverage=false ❌ Failed 11s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
nx run-many --target=build --parallel --exclude... ✅ Succeeded 10s View ↗
nx run eslint-plugin:test -- --coverage ✅ Succeeded 6m 29s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-18 15:01:48 UTC

@nayounsang nayounsang marked this pull request as draft June 21, 2025 11:14
@nayounsang
Copy link
Contributor Author

Why tests was failed in CI?
In my local, there was no problem.

@nayounsang
Copy link
Contributor Author

nayounsang commented Jun 23, 2025 •
edited
Loading

Can't reproduce test errors in local development.
In test, parseSettings.singleRun from packages/typescript-estree/src/parser.ts/parseAndGenerateServices is false.
So, it doesn't seem to be related to this commit.
I verified that the test results and (of course) the singleRun results did not change before and after the commit.
This work only affects singleRun.

@nayounsang nayounsang marked this pull request as ready for review June 23, 2025 08:07
@JoshuaKGoldberg JoshuaKGoldberg added awaiting response Issues waiting for a reply from the OP or another party and removed awaiting response Issues waiting for a reply from the OP or another party labels Jul 14, 2025
@JamesHenry JamesHenry assigned JamesHenry and unassigned JamesHenry Jul 15, 2025
@JamesHenry JamesHenry force-pushed the singlerun-true branch 2 times, most recently from fcdcb41 to de26768 Compare July 15, 2025 19:27
@JamesHenry
Copy link
Member

@JoshuaKGoldberg @nayounsang Ok this one drove me a little insane working my way to a reproduction, but it actually has nothing to do with caching, it is all to do with whether CI=true is set or not (which is why it happens only on CI and not locally by default).

In other words, you should be able to repro with:

CI=true TYPESCRIPT_ESLINT_PROJECT_SERVICE=true nx test typescript-estree --skip-nx-cache

@nayounsang
Copy link
Contributor Author

Thanks for helping us find the cause of this weird bug. Now let's fix our logic to fix the CI test failure.

@nayounsang nayounsang marked this pull request as draft July 18, 2025 11:22
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (0e884c7) to head (b0dcd4a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11327      +/-   ##
==========================================
- Coverage   90.86%   90.86%   -0.01%     
==========================================
  Files         503      503              
  Lines       51037    51026      -11     
  Branches     8424     8418       -6     
==========================================
- Hits        46374    46364      -10     
  Misses       4648     4648              
+ Partials       15       14       -1
Flag Coverage Δ
unittest 90.86% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...escript-estree/src/parseSettings/inferSingleRun.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@JamesHenry JamesHenry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(typescript-estree): never infers singleRun as true for project service
3 participants
@nayounsang @JamesHenry @JoshuaKGoldberg
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy