Skip to content

fix(typescript-eslint): address trailing path sep bug in tsconfigRootDir inference #11406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix(typescript-eslint): address trailing path sep bug in tsconfigRootDir inference #11406

wants to merge 3 commits into from
+38 −4

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Jul 17, 2025 •
edited
Loading

PR Checklist

Overview

Arcane regex tweaks to extract trailing path separators from the tsconfigRootDir.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 17, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9aa89c1
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/687943ddf9cecb000748d93c
😎 Deploy Preview https://deploy-preview-11406--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 17, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9aa89c1

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 27s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 8s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 6s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-17 18:47:25 UTC

@codecov Codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.86%. Comparing base (0e884c7) to head (9aa89c1).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11406   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files         503      503           
  Lines       51037    51039    +2     
  Branches     8424     8424           
=======================================
+ Hits        46374    46376    +2     
  Misses       4648     4648           
  Partials       15       15
Flag Coverage Δ
unittest 90.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pescript-eslint/src/getTSConfigRootDirFromStack.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@kirkwaiblinger @JoshuaKGoldberg
Update packages/typescript-eslint/tests/getTsconfigRootDirFromStack.t…
9aa89c1 
…est.ts

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@kirkwaiblinger kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Jul 17, 2025
@kirkwaiblinger kirkwaiblinger removed the request for review from JoshuaKGoldberg July 17, 2025 18:47
@kirkwaiblinger
Copy link
Member Author

Hang on — want to test a bit more

@kirkwaiblinger kirkwaiblinger marked this pull request as draft July 17, 2025 18:47
This was referenced Jul 18, 2025
Open
Open
Open
@JoshuaKGoldberg
Copy link
Member

Merged into #11408.

@kirkwaiblinger kirkwaiblinger deleted the fix-tsconfig-root-dir-path-inference branch July 18, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: inferring tsconfigRootDir fails with project: true
2 participants
@kirkwaiblinger @JoshuaKGoldberg
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy