From 4156b0ad5c9d7d522c825ffafde52ed9519c9029 Mon Sep 17 00:00:00 2001
From: Brad Zacher <brad.zacher@gmail.com>
Date: Mon, 6 Jul 2020 10:32:27 -0700
Subject: [PATCH] fix(eslint-plugin): [space-before-function-paren] incorrect
 handling of abstract functions

Fixes #2274
---
 .../src/rules/space-before-function-paren.ts   | 18 +++++++++++-------
 .../rules/space-before-function-paren.test.ts  | 13 +++++++++++++
 2 files changed, 24 insertions(+), 7 deletions(-)

diff --git a/packages/eslint-plugin/src/rules/space-before-function-paren.ts b/packages/eslint-plugin/src/rules/space-before-function-paren.ts
index f06327e2dd59..e2ccfa5182db 100644
--- a/packages/eslint-plugin/src/rules/space-before-function-paren.ts
+++ b/packages/eslint-plugin/src/rules/space-before-function-paren.ts
@@ -76,9 +76,10 @@ export default util.createRule<Options, MessageIds>({
         | TSESTree.ArrowFunctionExpression
         | TSESTree.FunctionDeclaration
         | TSESTree.FunctionExpression
-        | TSESTree.TSAbstractMethodDefinition,
+        | TSESTree.TSEmptyBodyFunctionExpression
+        | TSESTree.TSDeclareFunction,
     ): boolean {
-      if ('id' in node && node.id != null) {
+      if (node.id != null) {
         return true;
       }
 
@@ -102,7 +103,8 @@ export default util.createRule<Options, MessageIds>({
         | TSESTree.ArrowFunctionExpression
         | TSESTree.FunctionDeclaration
         | TSESTree.FunctionExpression
-        | TSESTree.TSAbstractMethodDefinition,
+        | TSESTree.TSEmptyBodyFunctionExpression
+        | TSESTree.TSDeclareFunction,
     ): FuncOption {
       if (node.type === AST_NODE_TYPES.ArrowFunctionExpression) {
         // Always ignore non-async functions and arrow functions without parens, e.g. async foo => bar
@@ -116,7 +118,7 @@ export default util.createRule<Options, MessageIds>({
         return overrideConfig.named ?? baseConfig;
 
         // `generator-star-spacing` should warn anonymous generators. E.g. `function* () {}`
-      } else if (!('generator' in node) || node.generator === false) {
+      } else if (!node.generator) {
         return overrideConfig.anonymous ?? baseConfig;
       }
 
@@ -133,7 +135,8 @@ export default util.createRule<Options, MessageIds>({
         | TSESTree.ArrowFunctionExpression
         | TSESTree.FunctionDeclaration
         | TSESTree.FunctionExpression
-        | TSESTree.TSAbstractMethodDefinition,
+        | TSESTree.TSEmptyBodyFunctionExpression
+        | TSESTree.TSDeclareFunction,
     ): void {
       const functionConfig = getConfigForFunction(node);
 
@@ -165,7 +168,7 @@ export default util.createRule<Options, MessageIds>({
       } else if (
         !hasSpacing &&
         functionConfig === 'always' &&
-        (!node.typeParameters || ('id' in node && node != null))
+        (!node.typeParameters || node.id)
       ) {
         context.report({
           node,
@@ -180,7 +183,8 @@ export default util.createRule<Options, MessageIds>({
       ArrowFunctionExpression: checkFunction,
       FunctionDeclaration: checkFunction,
       FunctionExpression: checkFunction,
-      TSAbstractMethodDefinition: checkFunction,
+      TSEmptyBodyFunctionExpression: checkFunction,
+      TSDeclareFunction: checkFunction,
     };
   },
 });
diff --git a/packages/eslint-plugin/tests/rules/space-before-function-paren.test.ts b/packages/eslint-plugin/tests/rules/space-before-function-paren.test.ts
index 5de3b0e6378d..13c68b88bc79 100644
--- a/packages/eslint-plugin/tests/rules/space-before-function-paren.test.ts
+++ b/packages/eslint-plugin/tests/rules/space-before-function-paren.test.ts
@@ -153,6 +153,19 @@ ruleTester.run('space-before-function-paren', rule, {
       code: 'abstract class Foo { constructor() {} abstract method() }',
       options: ['never'],
     },
+    {
+      code: 'abstract class Foo { constructor() {} abstract method() }',
+      options: [{ anonymous: 'always', named: 'never' }],
+    },
+    'function foo ();',
+    {
+      code: 'function foo();',
+      options: ['never'],
+    },
+    {
+      code: 'function foo();',
+      options: [{ anonymous: 'always', named: 'never' }],
+    },
   ],
 
   invalid: [

<!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>
<html xmlns='http://www.w3.org/1999/xhtml'>
<head>
<title>pFad - Phonifier reborn</title>
<meta http-equiv='Content-Type' content='text/html; charset=utf-8' />
</head>
<body>
<h1>Pfad - The Proxy pFad of &#169; 2024 Garber Painting. All rights reserved.</h1>


<!-- Disclaimer -->
<p>Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.</p>
<br>
<p>Alternative Proxies:</p><p><a href="http://rainy.clevelandohioweatherforecast.com/php-proxy/index.php?q=https://patch-diff.githubusercontent.com/raw/typescript-eslint/typescript-eslint/pull/2275.patch" target="_blank">Alternative Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/index.php?u=https://patch-diff.githubusercontent.com/raw/typescript-eslint/typescript-eslint/pull/2275.patch" target="_blank">pFad Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v3index.php?u=https://patch-diff.githubusercontent.com/raw/typescript-eslint/typescript-eslint/pull/2275.patch" target="_blank">pFad v3 Proxy</a></p><p><a href="http://rainy.clevelandohioweatherforecast.com/pFad/v4index.php?u=https://patch-diff.githubusercontent.com/raw/typescript-eslint/typescript-eslint/pull/2275.patch" target="_blank">pFad v4 Proxy</a></p></body>
</html>