diff --git a/packages/eslint-plugin/src/rules/consistent-type-definitions.ts b/packages/eslint-plugin/src/rules/consistent-type-definitions.ts
index efb7bdd8d5da..c71d812efd92 100644
--- a/packages/eslint-plugin/src/rules/consistent-type-definitions.ts
+++ b/packages/eslint-plugin/src/rules/consistent-type-definitions.ts
@@ -58,7 +58,7 @@ export default util.createRule({
const typeNode = node.typeParameters ?? node.id;
const fixes: TSESLint.RuleFix[] = [];
- const firstToken = sourceCode.getFirstToken(node);
+ const firstToken = sourceCode.getTokenBefore(node.id);
if (firstToken) {
fixes.push(fixer.replaceText(firstToken, 'interface'));
fixes.push(
@@ -98,7 +98,7 @@ export default util.createRule({
const typeNode = node.typeParameters ?? node.id;
const fixes: TSESLint.RuleFix[] = [];
- const firstToken = sourceCode.getFirstToken(node);
+ const firstToken = sourceCode.getTokenBefore(node.id);
if (firstToken) {
fixes.push(fixer.replaceText(firstToken, 'type'));
fixes.push(
diff --git a/packages/eslint-plugin/tests/rules/consistent-type-definitions.test.ts b/packages/eslint-plugin/tests/rules/consistent-type-definitions.test.ts
index f96672a213fc..9bcd9574986a 100644
--- a/packages/eslint-plugin/tests/rules/consistent-type-definitions.test.ts
+++ b/packages/eslint-plugin/tests/rules/consistent-type-definitions.test.ts
@@ -305,5 +305,51 @@ export default Test
},
],
},
+ {
+ // https://github.com/typescript-eslint/typescript-eslint/issues/4333
+ code: `
+export declare type Test = {
+ foo: string;
+ bar: string;
+};
+ `,
+ output: `
+export declare interface Test {
+ foo: string;
+ bar: string;
+}
+ `,
+ options: ['interface'],
+ errors: [
+ {
+ messageId: 'interfaceOverType',
+ line: 2,
+ column: 21,
+ },
+ ],
+ },
+ {
+ // https://github.com/typescript-eslint/typescript-eslint/issues/4333
+ code: `
+export declare interface Test {
+ foo: string;
+ bar: string;
+}
+ `,
+ output: noFormat`
+export declare type Test = {
+ foo: string;
+ bar: string;
+}
+ `,
+ options: ['type'],
+ errors: [
+ {
+ messageId: 'typeOverInterface',
+ line: 2,
+ column: 26,
+ },
+ ],
+ },
],
});
pFad - Phonifier reborn
Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.
Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.
Alternative Proxies:
Alternative Proxy
pFad Proxy
pFad v3 Proxy
pFad v4 Proxy