From 0db29e816fa481b199db3550084a0177fd29d09d Mon Sep 17 00:00:00 2001 From: Remi COMBE Date: Tue, 26 Apr 2022 11:27:06 +0200 Subject: [PATCH 1/3] eslint-plugin/rules/comma-spacing: add check to verify nextToken exists --- packages/eslint-plugin/src/rules/comma-spacing.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/eslint-plugin/src/rules/comma-spacing.ts b/packages/eslint-plugin/src/rules/comma-spacing.ts index 2774324d259b..1edd14dc93d8 100644 --- a/packages/eslint-plugin/src/rules/comma-spacing.ts +++ b/packages/eslint-plugin/src/rules/comma-spacing.ts @@ -177,7 +177,7 @@ export default createRule({ isCommaToken(prevToken) || ignoredTokens.has(token) ? null : prevToken, - isCommaToken(nextToken) || ignoredTokens.has(token) + nextToken && isCommaToken(nextToken) || ignoredTokens.has(token) ? null : nextToken, ); From bd42f7aa36bea1dd2cc58ad365efdd3bc1a3e933 Mon Sep 17 00:00:00 2001 From: Remi COMBE Date: Tue, 26 Apr 2022 12:51:34 +0200 Subject: [PATCH 2/3] fix(eslint-plugin): run prettier and use builtin functions --- packages/eslint-plugin/src/rules/comma-spacing.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/eslint-plugin/src/rules/comma-spacing.ts b/packages/eslint-plugin/src/rules/comma-spacing.ts index 1edd14dc93d8..336017db1b37 100644 --- a/packages/eslint-plugin/src/rules/comma-spacing.ts +++ b/packages/eslint-plugin/src/rules/comma-spacing.ts @@ -177,7 +177,7 @@ export default createRule({ isCommaToken(prevToken) || ignoredTokens.has(token) ? null : prevToken, - nextToken && isCommaToken(nextToken) || ignoredTokens.has(token) + (nextToken && isCommaToken(nextToken)) || ignoredTokens.has(token) ? null : nextToken, ); From d7154de5fddcb5fe6fda0d099ac7e23056eeb802 Mon Sep 17 00:00:00 2001 From: Remi COMBE Date: Wed, 27 Apr 2022 09:55:44 +0200 Subject: [PATCH 3/3] fix(eslint-plugin): [comma-spacing] add unit test --- .../eslint-plugin/tests/rules/comma-spacing.test.ts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/packages/eslint-plugin/tests/rules/comma-spacing.test.ts b/packages/eslint-plugin/tests/rules/comma-spacing.test.ts index 9ab7def96d97..37eb6e2e3adc 100644 --- a/packages/eslint-plugin/tests/rules/comma-spacing.test.ts +++ b/packages/eslint-plugin/tests/rules/comma-spacing.test.ts @@ -281,6 +281,7 @@ ruleTester.run('comma-spacing', rule, { 'class Foo {}', 'interface Foo{}', 'interface A<> {}', + 'let foo,', ], invalid: [ @@ -787,5 +788,17 @@ ruleTester.run('comma-spacing', rule, { }, ], }, + { + code: 'let foo ,', + output: 'let foo,', + errors: [ + { + messageId: 'unexpected', + column: 9, + line: 1, + data: { loc: 'before' }, + }, + ], + }, ], }); pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy