From 68bfc8d15af07635212b74f7af164621135ae78a Mon Sep 17 00:00:00 2001 From: yeonjuan Date: Fri, 1 Mar 2024 00:58:06 +0900 Subject: [PATCH 1/3] test(eslint-plugin): [no-unnecessary-type-assertion] add tests with noUncheckedIndexedAccess --- .../no-unnecessary-type-assertion.test.ts | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts b/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts index 3eb36636a839..948d40952e1f 100644 --- a/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts +++ b/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts @@ -13,6 +13,11 @@ const ruleTester = new RuleTester({ parser: '@typescript-eslint/parser', }); +const optionsWithOnUncheckedIndexedAccess = { + tsconfigRootDir: rootDir, + project: './tsconfig.noUncheckedIndexedAccess.json', +}; + ruleTester.run('no-unnecessary-type-assertion', rule, { valid: [ ` @@ -242,6 +247,17 @@ const item = arr[0] as object; declare const arr: (object | undefined)[]; const item = arr[0]; `, + { + code: ` +function foo(item: string) {} +function bar(items: string[]) { + for (let i = 0; i < items.length; i++) { + foo(items[i]!); + } +} + `, + parserOptions: optionsWithOnUncheckedIndexedAccess, + }, ], invalid: [ @@ -815,5 +831,31 @@ const foo = (3 + 5); }, ], }, + // onUncheckedIndexedAccess = false + { + code: ` +function foo(item: string) {} +function bar(items: string[]) { + for (let i = 0; i < items.length; i++) { + foo(items[i]!); + } +} + `, + output: ` +function foo(item: string) {} +function bar(items: string[]) { + for (let i = 0; i < items.length; i++) { + foo(items[i]); + } +} + `, + errors: [ + { + messageId: 'unnecessaryAssertion', + line: 5, + column: 9, + }, + ], + }, ], }); From 0de2bb7f8b3e9c48d378f13d0d6d62ba44656590 Mon Sep 17 00:00:00 2001 From: yeonjuan Date: Sun, 3 Mar 2024 16:00:08 +0900 Subject: [PATCH 2/3] set noUncheckedIndexedAccess false --- packages/eslint-plugin/tests/fixtures/tsconfig.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/eslint-plugin/tests/fixtures/tsconfig.json b/packages/eslint-plugin/tests/fixtures/tsconfig.json index 6ae5e64730b1..6b6e5bdc553b 100644 --- a/packages/eslint-plugin/tests/fixtures/tsconfig.json +++ b/packages/eslint-plugin/tests/fixtures/tsconfig.json @@ -6,7 +6,8 @@ "strict": true, "esModuleInterop": true, "lib": ["es2015", "es2017", "esnext"], - "experimentalDecorators": true + "experimentalDecorators": true, + "noUncheckedIndexedAccess": false }, "include": [ "file.ts", From ac7c4bf049eacd4388497ef527aaff146ac1680a Mon Sep 17 00:00:00 2001 From: yeonjuan Date: Sun, 3 Mar 2024 17:40:22 +0900 Subject: [PATCH 3/3] fixup --- packages/eslint-plugin/tests/fixtures/tsconfig.json | 3 +-- .../tests/rules/no-unnecessary-type-assertion.test.ts | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/eslint-plugin/tests/fixtures/tsconfig.json b/packages/eslint-plugin/tests/fixtures/tsconfig.json index 6b6e5bdc553b..6ae5e64730b1 100644 --- a/packages/eslint-plugin/tests/fixtures/tsconfig.json +++ b/packages/eslint-plugin/tests/fixtures/tsconfig.json @@ -6,8 +6,7 @@ "strict": true, "esModuleInterop": true, "lib": ["es2015", "es2017", "esnext"], - "experimentalDecorators": true, - "noUncheckedIndexedAccess": false + "experimentalDecorators": true }, "include": [ "file.ts", diff --git a/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts b/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts index 948d40952e1f..581cae6fb4e5 100644 --- a/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts +++ b/packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts @@ -6,6 +6,7 @@ import rule from '../../src/rules/no-unnecessary-type-assertion'; const rootDir = path.resolve(__dirname, '../fixtures/'); const ruleTester = new RuleTester({ parserOptions: { + EXPERIMENTAL_useProjectService: false, sourceType: 'module', tsconfigRootDir: rootDir, project: './tsconfig.json', pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy