From 07f5921c3398246a0315f9f8cd983f9998f1fe8e Mon Sep 17 00:00:00 2001 From: Abraham Guo Date: Sun, 28 Jul 2024 22:47:08 -0500 Subject: [PATCH] prefer-regexp-test --- eslint.config.mjs | 1 + packages/eslint-plugin/src/util/getWrappingFixer.ts | 2 +- packages/parser/tests/test-utils/test-utils.ts | 2 +- packages/typescript-estree/tests/test-utils/test-utils.ts | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/eslint.config.mjs b/eslint.config.mjs index 7715e4ddbdd9..8e95ff74bb5b 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -323,6 +323,7 @@ export default tseslint.config( 'jsdoc/informative-docs': 'error', 'unicorn/no-typeof-undefined': 'error', + 'unicorn/prefer-regexp-test': 'error', }, }, { diff --git a/packages/eslint-plugin/src/util/getWrappingFixer.ts b/packages/eslint-plugin/src/util/getWrappingFixer.ts index d5d07b6ba7e1..e6e71168fc41 100644 --- a/packages/eslint-plugin/src/util/getWrappingFixer.ts +++ b/packages/eslint-plugin/src/util/getWrappingFixer.ts @@ -67,7 +67,7 @@ export function getWrappingFixer( } // check if we need to insert semicolon - if (/^[`([]/.exec(code) && isMissingSemicolonBefore(node, sourceCode)) { + if (/^[`([]/.test(code) && isMissingSemicolonBefore(node, sourceCode)) { code = `;${code}`; } diff --git a/packages/parser/tests/test-utils/test-utils.ts b/packages/parser/tests/test-utils/test-utils.ts index a78f11dd3296..32a77d696042 100644 --- a/packages/parser/tests/test-utils/test-utils.ts +++ b/packages/parser/tests/test-utils/test-utils.ts @@ -59,7 +59,7 @@ export function createSnapshotTestBlock( * If we are deliberately throwing because of encountering an unknown * AST_NODE_TYPE, we rethrow to cause the test to fail */ - if (/Unknown AST_NODE_TYPE/.exec((error as Error).message)) { + if ((error as Error).message.includes('Unknown AST_NODE_TYPE')) { throw error; } expect(parse).toThrowErrorMatchingSnapshot(); diff --git a/packages/typescript-estree/tests/test-utils/test-utils.ts b/packages/typescript-estree/tests/test-utils/test-utils.ts index 6acf026f5d0a..e4d4b454ae13 100644 --- a/packages/typescript-estree/tests/test-utils/test-utils.ts +++ b/packages/typescript-estree/tests/test-utils/test-utils.ts @@ -44,7 +44,7 @@ export function createSnapshotTestBlock( * If we are deliberately throwing because of encountering an unknown * AST_NODE_TYPE, we rethrow to cause the test to fail */ - if (/Unknown AST_NODE_TYPE/.exec((error as Error).message)) { + if ((error as Error).message.includes('Unknown AST_NODE_TYPE')) { throw error; } expect(parse).toThrowErrorMatchingSnapshot(); pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy