Skip to content

Commit 059a6be

Browse files
committed
General (+Chisel3 compatibility) cleanup.
Have top level clean remove entire generated output directory. Have check script look for either old or new PASSED|FAILED lines - I realize supporting both introduces a level of ambiguity. Supposedly we have enough control over this to reduce the likelihood to zero. Have the check target dependent on the generated output directory.
1 parent f4dcf58 commit 059a6be

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

Makefile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ top_srcdir ?= .
44
include objdirroot.mk
55

66
# Directories removed by make clean
7-
RM_DIRS := emulator project/target target
7+
RM_DIRS := emulator project/target target $(objdirroot)
88

99
# All subdirectories
1010
ALL_SUB_DIRS := examples hello problems solutions
@@ -67,8 +67,7 @@ jenkins-build: clean smoke check
6767
# GenSubDirTargets generates a dependency:
6868
# clean: $(_cleaners)
6969
clean:
70-
$(RM) $(objdirroot)/test-solutions.xml
71-
if [ "$(RM_DIRS)" ] ; then $(RM) -r $(RM_DIRS); fi
70+
if [ -n "$(RM_DIRS)" ] ; then $(RM) -r $(RM_DIRS); fi
7271

7372
# GenSubDirTargets generates dependencies:
7473
# smoke: $(_smokeers)

sbt/check

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def main(args, junit_file):
1616
test_status = 'FAILED'
1717
test_time = 0
1818
for line in outfile.readlines():
19-
look = re.match(r'RAN \d+ CYCLES (PASSED)|(FAILED)', line)
19+
look = re.match(r'RAN \d+ CYCLES (PASSED)|(FAILED)', line) or re.match(r'(PASSED|FAILED)', line)
2020
if look:
2121
test_status = look.group(1)
2222
look = re.match(r'.*Total time: (\S+) s,', line)

suffix.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ default: all
5353

5454
all: outs verilog # dreamer
5555

56-
check: $(objdir)/test-solutions.xml
56+
check: $(objdir) $(objdir)/test-solutions.xml
5757

5858
clean: $(filter-out $(wildcard $objdir),$(objdir)) $(objdir)
5959
cd $(objdir) && $(RM) $(generated_files)

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy