CrasingTestsAreReportedAsFailures no longer core dumps on Clang Release

Dan Huantes · Dan Huantes · commit 2423fcac7668 · 2019-08-15T08:30:43.000-05:00
Found that Crashing tests at some point in Clang
history were actually caught but testing on
Clang 6.0 and Clang 7.0 this is not the case.
So added Clang to the list of compilers that
don't run this tests.  Noted that several
other Pull Requests were failing for the same
reason.
diff --git a/tests/TestTest.cpp b/tests/TestTest.cpp
@@ -72,7 +72,7 @@ namespace {
       CHECK_EQUAL(1, results.GetFailureCount());
    }
 
-#if !defined(UNITTEST_MINGW) && !defined(UNITTEST_WIN32)
+#if !defined(UNITTEST_MINGW) && !defined(UNITTEST_WIN32) && !defined(__clang__)
 // Skip this test in debug because some debuggers don't like it.
 #if defined(NDEBUG)
    TEST(CrashingTestsAreReportedAsFailures)

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ namespace {`
`72`	`72`	`CHECK_EQUAL(1, results.GetFailureCount());`
`73`	`73`	`}`
`74`	`74`
`75`		`-#if !defined(UNITTEST_MINGW) && !defined(UNITTEST_WIN32)`
	`75`	`+#if !defined(UNITTEST_MINGW) && !defined(UNITTEST_WIN32) && !defined(__clang__)`
`76`	`76`	`// Skip this test in debug because some debuggers don't like it.`
`77`	`77`	`#if defined(NDEBUG)`
`78`	`78`	`TEST(CrashingTestsAreReportedAsFailures)`