In timeout options, reword the message only of TypeError

encukou · encukou · commit 12f193efaeae · 2017-12-07T21:11:34.000+01:00
diff --git a/Modules/options.c b/Modules/options.c
@@ -136,20 +136,22 @@ LDAP_set_option(LDAPObject *self, int option, PyObject *value)
 	    break;
     case LDAP_OPT_TIMEOUT:
     case LDAP_OPT_NETWORK_TIMEOUT:
-        /* Float valued timeval options, 'd' also handles int/long */
-        if (!PyArg_Parse(value, "d:set_option", &doubleval)) {
-            /* clear error and try again with None */
-            PyErr_Clear();
-            if (PyNone_Check(value)) {
-                /* None is mapped to infinity timeout */
-                doubleval = -1;
-            }
-            else {
-                PyErr_Format(
-                    PyExc_TypeError,
-                    "A float or None is expected for timeout, got %.100s",
-                    Py_TYPE(value)->tp_name
-                );
+        /* Float valued timeval options */
+        if (value == Py_None) {
+            /* None is mapped to infinity timeout */
+            doubleval = -1;
+        } else {
+            /* 'd' handles int/long */
+            if (!PyArg_Parse(value, "d:set_option", &doubleval)) {
+                if (PyErr_ExceptionMatches(PyExc_TypeError)) {
+                    /* TypeError: mention either float or None is expected */
+                    PyErr_Clear();
+                    PyErr_Format(
+                        PyExc_TypeError,
+                        "A float or None is expected for timeout, got %.100s",
+                        Py_TYPE(value)->tp_name
+                    );
+                }
                 return 0;
             }
         }
diff --git a/Tests/t_ldap_options.py b/Tests/t_ldap_options.py
@@ -64,6 +64,8 @@ def _test_timeout(self, option):
             self._check_option(option, -5)
         with self.assertRaises(TypeError):
             self.set_option(option, object)
+        with self.assertRaises(OverflowError):
+            self._check_option(option, 10**1000)
         old = self.get_option(option)
         try:
             self.set_option(option, None)
