sagemathgh-40392: moving two methods to the categories of rings and fields

Release Manager · Release Manager · commit 1b36a5e7ac94 · 2025-07-14T21:14:08.000+02:00
as another step towards getting rid of the auld `Ring` class. - epsilon method to Rings : This method is apparently not used anywhere inside sage. Let's assume it may be used somewhere outside in the wild. - an_embedding method to Fields - also removing a duplicate method in the category of Fields ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40392 Reported by: Frédéric Chapoton Reviewer(s):
diff --git a/build/pkgs/configure/checksums.ini b/build/pkgs/configure/checksums.ini
@@ -1,3 +1,3 @@
 tarball=configure-VERSION.tar.gz
-sha1=e4a5aaaa785d20ffb9a1a2e6bb0420bfc3d2c1db
-sha256=eaf5cb555f81f8c84f84e7aae69e3e1238e8e971723d31833f6787bd5be1aea5
+sha1=67b7bde0cd4b84da82fd0f59930f4b3a203f652b
+sha256=2b73756c59bb266c2bf1bdf522fe0a3d511c2d7bbf95f803a8f5579853b8f95e
diff --git a/build/pkgs/configure/package-version.txt b/build/pkgs/configure/package-version.txt
@@ -1 +1 @@
-25fc6f0d11318fc70ba7b3c44e0e3aed45be8b23
+5689e2b6ea8b8752e614957df1f0a93e5668b3f4
diff --git a/src/doc/en/thematic_tutorials/coercion_and_categories.rst b/src/doc/en/thematic_tutorials/coercion_and_categories.rst
@@ -120,9 +120,7 @@ as this base class still provides a few more methods than a general parent::
      '_one_element',
      '_pseudo_fraction_field',
      '_zero_element',
-     'an_embedding',
      'base_extend',
-     'epsilon',
      'extension',
      'fraction_field',
      'gen',
diff --git a/src/sage/categories/fields.py b/src/sage/categories/fields.py
@@ -277,6 +277,58 @@ def algebraic_closure(self):
             """
             raise NotImplementedError("algebraic closures of general fields not implemented")
 
+        def an_embedding(self, K):
+            r"""
+            Return some embedding of this field into another field `K`,
+            and raise a :class:`ValueError` if none exists.
+
+            EXAMPLES::
+
+                sage: GF(2).an_embedding(GF(4))
+                Ring morphism:
+                  From: Finite Field of size 2
+                  To:   Finite Field in z2 of size 2^2
+                  Defn: 1 |--> 1
+                sage: GF(4).an_embedding(GF(8))
+                Traceback (most recent call last):
+                ...
+                ValueError: no embedding from Finite Field in z2 of size 2^2 to Finite Field in z3 of size 2^3
+                sage: GF(4).an_embedding(GF(16))
+                Ring morphism:
+                  From: Finite Field in z2 of size 2^2
+                  To:   Finite Field in z4 of size 2^4
+                  Defn: z2 |--> z4^2 + z4
+
+            ::
+
+                sage: CyclotomicField(5).an_embedding(QQbar)
+                Coercion map:
+                  From: Cyclotomic Field of order 5 and degree 4
+                  To:   Algebraic Field
+                sage: CyclotomicField(3).an_embedding(CyclotomicField(7))
+                Traceback (most recent call last):
+                ...
+                ValueError: no embedding from Cyclotomic Field of order 3 and degree 2 to Cyclotomic Field of order 7 and degree 6
+                sage: CyclotomicField(3).an_embedding(CyclotomicField(6))
+                Generic morphism:
+                  From: Cyclotomic Field of order 3 and degree 2
+                  To:   Cyclotomic Field of order 6 and degree 2
+                  Defn: zeta3 -> zeta6 - 1
+            """
+            if self.characteristic() != K.characteristic():
+                raise ValueError(f'no embedding from {self} to {K}: incompatible characteristics')
+
+            H = self.Hom(K)
+            try:
+                return H.natural_map()
+            except TypeError:
+                pass
+            from sage.categories.sets_cat import EmptySetError
+            try:
+                return H.an_element()
+            except EmptySetError:
+                raise ValueError(f'no embedding from {self} to {K}')
+
         def prime_subfield(self):
             """
             Return the prime subfield of ``self``.
@@ -699,22 +751,6 @@ def vector_space(self, *args, **kwds):
             """
             return self.free_module(*args, **kwds)
 
-        def _pseudo_fraction_field(self):
-            """
-            The fraction field of ``self`` is always available as ``self``.
-
-            EXAMPLES::
-
-                sage: QQ._pseudo_fraction_field()
-                Rational Field
-                sage: K = GF(5)
-                sage: K._pseudo_fraction_field()
-                Finite Field of size 5
-                sage: K._pseudo_fraction_field() is K
-                True
-            """
-            return self
-
     class ElementMethods:
         def euclidean_degree(self):
             r"""
diff --git a/src/sage/categories/rings.py b/src/sage/categories/rings.py
@@ -1747,6 +1747,67 @@ def random_element(self, *args):
                 a, b = args[0], args[1]
             return randint(a, b) * self.one()
 
+        @cached_method
+        def epsilon(self):
+            """
+            Return the precision error of elements in this ring.
+
+            .. NOTE:: This is not used anywhere inside the code base.
+
+            EXAMPLES::
+
+                sage: RDF.epsilon()
+                2.220446049250313e-16
+                sage: ComplexField(53).epsilon()                                            # needs sage.rings.real_mpfr
+                2.22044604925031e-16
+                sage: RealField(10).epsilon()                                               # needs sage.rings.real_mpfr
+                0.0020
+
+            For exact rings, zero is returned::
+
+                sage: ZZ.epsilon()
+                0
+
+            This also works over derived rings::
+
+                sage: RR['x'].epsilon()                                                     # needs sage.rings.real_mpfr
+                2.22044604925031e-16
+                sage: QQ['x'].epsilon()
+                0
+
+            For the symbolic ring, there is no reasonable answer::
+
+                sage: SR.epsilon()                                                          # needs sage.symbolic
+                Traceback (most recent call last):
+                ...
+                NotImplementedError
+            """
+            one = self.one()
+
+            # ulp is only defined in some real fields
+            try:
+                return one.ulp()
+            except AttributeError:
+                pass
+
+            try:
+                eps = one.real().ulp()
+            except AttributeError:
+                pass
+            else:
+                return self(eps)
+
+            if self.is_exact():
+                return self.zero()
+
+            S = self.base_ring()
+            if self is not S:
+                try:
+                    return self(S.epsilon())
+                except AttributeError:
+                    pass
+            raise NotImplementedError
+
     class ElementMethods:
         def is_unit(self) -> bool:
             r"""
diff --git a/src/sage/rings/ring.pyx b/src/sage/rings/ring.pyx
@@ -484,59 +484,6 @@ cdef class Ring(ParentWithGens):
             return 1
         raise NotImplementedError
 
-    @cached_method
-    def epsilon(self):
-        """
-        Return the precision error of elements in this ring.
-
-        EXAMPLES::
-
-            sage: RDF.epsilon()
-            2.220446049250313e-16
-            sage: ComplexField(53).epsilon()                                            # needs sage.rings.real_mpfr
-            2.22044604925031e-16
-            sage: RealField(10).epsilon()                                               # needs sage.rings.real_mpfr
-            0.0020
-
-        For exact rings, zero is returned::
-
-            sage: ZZ.epsilon()
-            0
-
-        This also works over derived rings::
-
-            sage: RR['x'].epsilon()                                                     # needs sage.rings.real_mpfr
-            2.22044604925031e-16
-            sage: QQ['x'].epsilon()
-            0
-
-        For the symbolic ring, there is no reasonable answer::
-
-            sage: SR.epsilon()                                                          # needs sage.symbolic
-            Traceback (most recent call last):
-            ...
-            NotImplementedError
-        """
-        one = self.one()
-        try:
-            return one.ulp()
-        except AttributeError:
-            pass
-
-        try:
-            eps = one.real().ulp()
-        except AttributeError:
-            pass
-        else:
-            return self(eps)
-
-        B = self._base
-        if B is not None and B is not self:
-            eps = self.base_ring().epsilon()
-            return self(eps)
-        if self.is_exact():
-            return self.zero()
-        raise NotImplementedError
 
 cdef class CommutativeRing(Ring):
     """
@@ -757,58 +704,6 @@ cdef class Field(CommutativeRing):
     """
     _default_category = _Fields
 
-    def an_embedding(self, K):
-        r"""
-        Return some embedding of this field into another field `K`,
-        and raise a :class:`ValueError` if none exists.
-
-        EXAMPLES::
-
-            sage: GF(2).an_embedding(GF(4))
-            Ring morphism:
-              From: Finite Field of size 2
-              To:   Finite Field in z2 of size 2^2
-              Defn: 1 |--> 1
-            sage: GF(4).an_embedding(GF(8))
-            Traceback (most recent call last):
-            ...
-            ValueError: no embedding from Finite Field in z2 of size 2^2 to Finite Field in z3 of size 2^3
-            sage: GF(4).an_embedding(GF(16))
-            Ring morphism:
-              From: Finite Field in z2 of size 2^2
-              To:   Finite Field in z4 of size 2^4
-              Defn: z2 |--> z4^2 + z4
-
-        ::
-
-            sage: CyclotomicField(5).an_embedding(QQbar)
-            Coercion map:
-              From: Cyclotomic Field of order 5 and degree 4
-              To:   Algebraic Field
-            sage: CyclotomicField(3).an_embedding(CyclotomicField(7))
-            Traceback (most recent call last):
-            ...
-            ValueError: no embedding from Cyclotomic Field of order 3 and degree 2 to Cyclotomic Field of order 7 and degree 6
-            sage: CyclotomicField(3).an_embedding(CyclotomicField(6))
-            Generic morphism:
-              From: Cyclotomic Field of order 3 and degree 2
-              To:   Cyclotomic Field of order 6 and degree 2
-              Defn: zeta3 -> zeta6 - 1
-        """
-        if self.characteristic() != K.characteristic():
-            raise ValueError(f'no embedding from {self} to {K}: incompatible characteristics')
-
-        H = self.Hom(K)
-        try:
-            return H.natural_map()
-        except TypeError:
-            pass
-        from sage.categories.sets_cat import EmptySetError
-        try:
-            return H.an_element()
-        except EmptySetError:
-            raise ValueError(f'no embedding from {self} to {K}')
-
 
 cdef class Algebra(Ring):
     def __init__(self, base_ring, *args, **kwds):

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-25fc6f0d11318fc70ba7b3c44e0e3aed45be8b23`
	`1`	`+5689e2b6ea8b8752e614957df1f0a93e5668b3f4`