Add comments and make this releseable.

arunoda · arunoda · commit 914c7fb926c5 · 2017-03-23T11:08:42.000+05:30
diff --git a/server/build/index.js b/server/build/index.js
@@ -46,6 +46,10 @@ function runCompiler (compiler) {
 }
 
 async function writeBuildStats (dir) {
+  // Here we can't use the hash in chunks.
+  // That's because app.js has no related chunk.
+  // It's created with merging the few assets. (commons.js and main.js)
+  // So, we need to generate the hash ourself.
   const assetHashMap = {
     'app.js': {
       hash: await md5File(join(dir, '.next', 'app.js'))
diff --git a/server/build/plugins/combine-assets-plugin.js b/server/build/plugins/combine-assets-plugin.js
@@ -1,19 +1,21 @@
+// This pulgin merge a set of assets into a single asset
+// This should be only used with text assets,
+// otherwise the result is unpredictable.
 export default class CombineAssetsPlugin {
+  constructor ({ input, output }) {
+    this.input = input
+    this.output = output
+  }
+
   apply (compiler) {
     compiler.plugin('after-compile', (compilation, callback) => {
-      const input = [
-        'commons.js',
-        'main.js'
-      ]
-      const output = 'app.js'
-
       let newSource = ''
-      input.forEach((name) => {
+      this.input.forEach((name) => {
         newSource += `${compilation.assets[name].source()}\n`
         delete compilation.assets[name]
       })
 
-      compilation.assets[output] = {
+      compilation.assets[this.output] = {
         source: () => newSource,
         size: () => newSource.length
       }
diff --git a/server/build/webpack.js b/server/build/webpack.js
@@ -120,7 +120,10 @@ export default async function createCompiler (dir, { dev = false, quiet = false,
     }
   } else {
     plugins.push(
-      new CombineAssetsPlugin(),
+      new CombineAssetsPlugin({
+        input: ['commons.js', 'main.js'],
+        output: 'app.js'
+      }),
       new webpack.optimize.UglifyJsPlugin({
         compress: { warnings: false },
         sourceMap: false
diff --git a/server/document.js b/server/document.js
@@ -80,6 +80,8 @@ export class NextScript extends Component {
       )
     }
 
+    // In the production mode, we have a single asset
+    // So, we can load the script with async
     return this.getChunkScript('app.js', { async: true })
   }
 

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,8 @@ export class NextScript extends Component {`
`80`	`80`	`)`
`81`	`81`	`}`
`82`	`82`
	`83`	`+ // In the production mode, we have a single asset`
	`84`	`+ // So, we can load the script with async`
`83`	`85`	`return this.getChunkScript('app.js', { async: true })`
`84`	`86`	`}`
`85`	`87`