fix(ssr): handle function expression name scoping (#16563)

bluwy · web-flow · commit 02db9479acfa · 2024-05-01T16:30:22.000+08:00
diff --git a/packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts b/packages/vite/src/node/ssr/__tests__/ssrTransform.spec.ts
@@ -249,6 +249,28 @@ test('do not rewrite when function declaration is in scope', async () => {
   expect(result?.deps).toEqual(['vue'])
 })
 
+// #16452
+test('do not rewrite when function expression is in scope', async () => {
+  const result = await ssrTransformSimple(
+    `import {fn} from './vue';var a = function() { return function fn() { console.log(fn) } }`,
+  )
+  expect(result?.code).toMatchInlineSnapshot(`
+    "const __vite_ssr_import_0__ = await __vite_ssr_import__("./vue", {"importedNames":["fn"]});
+    var a = function() { return function fn() { console.log(fn) } }"
+  `)
+})
+
+// #16452
+test('do not rewrite when function expression is in global scope', async () => {
+  const result = await ssrTransformSimple(
+    `import {fn} from './vue';foo(function fn(a = fn) { console.log(fn) })`,
+  )
+  expect(result?.code).toMatchInlineSnapshot(`
+    "const __vite_ssr_import_0__ = await __vite_ssr_import__("./vue", {"importedNames":["fn"]});
+    foo(function fn(a = fn) { console.log(fn) })"
+  `)
+})
+
 test('do not rewrite catch clause', async () => {
   const result = await ssrTransformSimple(
     `import {error} from './dependency';try {} catch(error) {}`,
diff --git a/packages/vite/src/node/ssr/ssrTransform.ts b/packages/vite/src/node/ssr/ssrTransform.ts
@@ -442,6 +442,11 @@ function walk(
             setScope(parentScope, node.id!.name)
           }
         }
+        // If it is a function expression, its name (if exist) could also be
+        // shadowing an import. So add its own name to the scope
+        if (node.type === 'FunctionExpression' && node.id) {
+          setScope(node, node.id.name)
+        }
         // walk function expressions and add its arguments to known identifiers
         // so that we don't prefix them
         node.params.forEach((p) => {

Original file line number	Diff line number	Diff line change
`@@ -442,6 +442,11 @@ function walk(`
`442`	`442`	`setScope(parentScope, node.id!.name)`
`443`	`443`	`}`
`444`	`444`	`}`
	`445`	`+ // If it is a function expression, its name (if exist) could also be`
	`446`	`+ // shadowing an import. So add its own name to the scope`
	`447`	`+ if (node.type === 'FunctionExpression' && node.id) {`
	`448`	`+ setScope(node, node.id.name)`
	`449`	`+ }`
`445`	`450`	`// walk function expressions and add its arguments to known identifiers`
`446`	`451`	`// so that we don't prefix them`
`447`	`452`	`node.params.forEach((p) => {`