fix: button wave memory leak

tangjinzhou · tangjinzhou · commit bb443a05e249 · 2024-09-13T19:05:04.000+08:00
diff --git a/components/_util/wave/WaveEffect.tsx b/components/_util/wave/WaveEffect.tsx
@@ -159,6 +159,12 @@ function showWaveEffect(node: HTMLElement, className: string) {
   node?.insertBefore(holder, node?.firstChild);
 
   render(<WaveEffect target={node} className={className} />, holder);
+  return () => {
+    render(null, holder);
+    if (holder.parentElement) {
+      holder.parentElement.removeChild(holder);
+    }
+  };
 }
 
 export default showWaveEffect;
diff --git a/components/_util/wave/index.tsx b/components/_util/wave/index.tsx
@@ -33,13 +33,12 @@ export default defineComponent({
 
     // =============================== Wave ===============================
     const showWave = useWave(
-      instance,
       computed(() => classNames(prefixCls.value, hashId.value)),
       wave,
     );
     let onClick: (e: MouseEvent) => void;
     const clear = () => {
-      const node = findDOMNode(instance);
+      const node = findDOMNode(instance) as HTMLElement;
       node.removeEventListener('click', onClick, true);
     };
     onMounted(() => {
diff --git a/components/_util/wave/useWave.ts b/components/_util/wave/useWave.ts
@@ -1,21 +1,25 @@
-import type { ComponentInternalInstance, ComputedRef, Ref } from 'vue';
+import type { ComputedRef, Ref } from 'vue';
+import { onBeforeUnmount, getCurrentInstance } from 'vue';
 import { findDOMNode } from '../props-util';
 import showWaveEffect from './WaveEffect';
 
 export default function useWave(
-  instance: ComponentInternalInstance | null,
   className: Ref<string>,
   wave?: ComputedRef<{ disabled?: boolean }>,
 ): VoidFunction {
+  const instance = getCurrentInstance();
+  let stopWave: () => void;
   function showWave() {
     const node = findDOMNode(instance);
-
+    stopWave?.();
     if (wave?.value?.disabled || !node) {
       return;
     }
-
-    showWaveEffect(node, className.value);
+    stopWave = showWaveEffect(node, className.value);
   }
+  onBeforeUnmount(() => {
+    stopWave?.();
+  });
 
   return showWave;
 }
