Improve error range for vue/max-props (#2532)

kevsommer · web-flow · commit 0fbe35e0b1cb · 2024-08-20T16:07:08.000+02:00
diff --git a/lib/rules/max-props.js b/lib/rules/max-props.js
@@ -43,7 +43,7 @@ module.exports = {
     function checkMaxNumberOfProps(props) {
       if (props.length > option.maxProps && props[0].node) {
         context.report({
-          node: props[0].node,
+          node: props[0].node.parent,
           messageId: 'tooManyProps',
           data: {
             propCount: props.length,
diff --git a/tests/lib/rules/max-props.js b/tests/lib/rules/max-props.js
@@ -113,7 +113,8 @@ tester.run('max-props', rule, {
       errors: [
         {
           message: 'Component has too many props (2). Maximum allowed is 1.',
-          line: 3
+          line: 3,
+          endLine: 3
         }
       ]
     },
@@ -133,7 +134,8 @@ tester.run('max-props', rule, {
       errors: [
         {
           message: 'Component has too many props (2). Maximum allowed is 1.',
-          line: 5
+          line: 4,
+          endLine: 7
         }
       ]
     },
@@ -154,7 +156,8 @@ tester.run('max-props', rule, {
       errors: [
         {
           message: 'Component has too many props (3). Maximum allowed is 2.',
-          line: 3
+          line: 3,
+          endLine: 3
         }
       ]
     }

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,8 @@ tester.run('max-props', rule, {`
`113`	`113`	`errors: [`
`114`	`114`	`{`
`115`	`115`	`message: 'Component has too many props (2). Maximum allowed is 1.',`
`116`		`- line: 3`
	`116`	`+ line: 3,`
	`117`	`+ endLine: 3`
`117`	`118`	`}`
`118`	`119`	`]`
`119`	`120`	`},`
`@@ -133,7 +134,8 @@ tester.run('max-props', rule, {`
`133`	`134`	`errors: [`
`134`	`135`	`{`
`135`	`136`	`message: 'Component has too many props (2). Maximum allowed is 1.',`
`136`		`- line: 5`
	`137`	`+ line: 4,`
	`138`	`+ endLine: 7`
`137`	`139`	`}`
`138`	`140`	`]`
`139`	`141`	`},`
`@@ -154,7 +156,8 @@ tester.run('max-props', rule, {`
`154`	`156`	`errors: [`
`155`	`157`	`{`
`156`	`158`	`message: 'Component has too many props (3). Maximum allowed is 2.',`
`157`		`- line: 3`
	`159`	`+ line: 3,`
	`160`	`+ endLine: 3`
`158`	`161`	`}`
`159`	`162`	`]`
`160`	`163`	`}`