Fixed #648 (#649)

ota-meshi · michalsnik · commit 7bb543803669 · 2018-11-12T22:45:34.000+01:00
diff --git a/lib/rules/valid-v-model.js b/lib/rules/valid-v-model.js
@@ -156,7 +156,8 @@ module.exports = {
               context.report({
                 node,
                 loc: node.loc,
-                message: "'v-model' directives cannot update the iteration variable 'x' itself."
+                message: "'v-model' directives cannot update the iteration variable '{{varName}}' itself.",
+                data: { varName: id.name }
               })
             }
           }
diff --git a/tests/lib/rules/valid-v-model.js b/tests/lib/rules/valid-v-model.js
@@ -161,6 +161,11 @@ tester.run('valid-v-model', rule, {
       filename: 'test.vue',
       code: '<template><div><div v-for="x in list"><input v-model="(((x)))"></div></div></template>',
       errors: ["'v-model' directives cannot update the iteration variable 'x' itself."]
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div><div v-for="e in list"><input v-model="e"></div></div></template>',
+      errors: ["'v-model' directives cannot update the iteration variable 'e' itself."]
     }
   ]
 })

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,8 @@ module.exports = {`
`156`	`156`	`context.report({`
`157`	`157`	`node,`
`158`	`158`	`loc: node.loc,`
`159`		`- message: "'v-model' directives cannot update the iteration variable 'x' itself."`
	`159`	`+ message: "'v-model' directives cannot update the iteration variable '{{varName}}' itself.",`
	`160`	`+ data: { varName: id.name }`
`160`	`161`	`})`
`161`	`162`	`}`
`162`	`163`	`}`
Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,11 @@ tester.run('valid-v-model', rule, {`
`161`	`161`	`filename: 'test.vue',`
`162`	`162`	`code: '<template><div><div v-for="x in list"><input v-model="(((x)))"></div></div></template>',`
`163`	`163`	`errors: ["'v-model' directives cannot update the iteration variable 'x' itself."]`
	`164`	`+ },`
	`165`	`+ {`
	`166`	`+ filename: 'test.vue',`
	`167`	`+ code: '<template><div><div v-for="e in list"><input v-model="e"></div></div></template>',`
	`168`	`+ errors: ["'v-model' directives cannot update the iteration variable 'e' itself."]`
`164`	`169`	`}`
`165`	`170`	`]`
`166`	`171`	`})`