Fix reporting issues from executeOnFunctionsWithoutReturn (#655)

armano2 · michalsnik · commit adb4a0db2c8e · 2018-11-18T13:03:34.000+01:00
diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -685,8 +685,12 @@ module.exports = {
       node: null
     }
 
+    function isReachable (segment) {
+      return segment.reachable
+    }
+
     function isValidReturn () {
-      if (!funcInfo.hasReturn) {
+      if (funcInfo.codePath.currentSegments.some(isReachable)) {
         return false
       }
       return !treatUndefinedAsUnspecified || funcInfo.hasReturnValue
diff --git a/tests/lib/rules/require-render-return.js b/tests/lib/rules/require-render-return.js
@@ -70,6 +70,36 @@ ruleTester.run('require-render-return', rule, {
       }`,
       parserOptions
     },
+    {
+      filename: 'test.vue',
+      code: `export default {
+        render() {
+          const foo = function () {}
+          return foo
+        }
+      }`,
+      parserOptions
+    },
+    {
+      filename: 'test.vue',
+      code: `export default {
+        render() {
+          if (a) {
+            if (b) {
+              
+            }
+            if (c) {
+              return true
+            } else {
+              return foo
+            }
+          } else {
+            return foo
+          }
+        }
+      }`,
+      parserOptions
+    },
     {
       filename: 'test.vue',
       code: `export default {
@@ -119,6 +149,22 @@ ruleTester.run('require-render-return', rule, {
         line: 2
       }]
     },
+    {
+      filename: 'test.vue',
+      code: `export default {
+        render: function () {
+          if (foo) {
+            return h('div', 'hello')
+          }
+        }
+      }`,
+      parserOptions,
+      errors: [{
+        message: 'Expected to return a value in render function.',
+        type: 'Identifier',
+        line: 2
+      }]
+    },
     {
       code: `Vue.component('test', {
         render: function () {
@@ -133,6 +179,38 @@ ruleTester.run('require-render-return', rule, {
         type: 'Identifier',
         line: 2
       }]
+    },
+    {
+      code: `Vue.component('test2', {
+        render: function () {
+          if (a) {
+            return h('div', 'hello')
+          }
+        }
+      })`,
+      parserOptions,
+      errors: [{
+        message: 'Expected to return a value in render function.',
+        type: 'Identifier',
+        line: 2
+      }]
+    },
+    {
+      code: `Vue.component('test2', {
+        render: function () {
+          if (a) {
+            
+          } else {
+            return h('div', 'hello')
+          }
+        }
+      })`,
+      parserOptions,
+      errors: [{
+        message: 'Expected to return a value in render function.',
+        type: 'Identifier',
+        line: 2
+      }]
     }
   ]
 })

Original file line number	Diff line number	Diff line change
`@@ -685,8 +685,12 @@ module.exports = {`
`685`	`685`	`node: null`
`686`	`686`	`}`
`687`	`687`
	`688`	`+ function isReachable (segment) {`
	`689`	`+ return segment.reachable`
	`690`	`+ }`
	`691`	`+`
`688`	`692`	`function isValidReturn () {`
`689`		`- if (!funcInfo.hasReturn) {`
	`693`	`+ if (funcInfo.codePath.currentSegments.some(isReachable)) {`
`690`	`694`	`return false`
`691`	`695`	`}`
`692`	`696`	`return !treatUndefinedAsUnspecified \|\| funcInfo.hasReturnValue`