refactor: move more into pluginResolution util

yyx990803 · yyx990803 · commit 4601cc34b2ce · 2018-03-05T11:09:21.000-05:00
diff --git a/packages/@vue/cli-shared-utils/lib/pluginResolution.js b/packages/@vue/cli-shared-utils/lib/pluginResolution.js
@@ -40,3 +40,20 @@ exports.matchesPluginId = (input, full) => {
     short === input.replace(scopeRE, '')
   )
 }
+
+exports.getPluginLink = id => {
+  if (officialRE.test(id)) {
+    return `https://github.com/vuejs/vue-cli/tree/dev/packages/%40vue/cli-plugin-${
+      exports.toShortPluginId(id)
+    }`
+  }
+  let pkg = {}
+  try {
+    pkg = require(`${id}/package.json`)
+  } catch (e) {}
+  return (
+    pkg.homepage ||
+    (pkg.repository && pkg.repository.url) ||
+    `https://www.npmjs.com/package/${id.replace(`/`, `%2F`)}`
+  )
+}
diff --git a/packages/@vue/cli/lib/GeneratorAPI.js b/packages/@vue/cli/lib/GeneratorAPI.js
@@ -5,25 +5,12 @@ const globby = require('globby')
 const isBinary = require('isbinaryfile')
 const yaml = require('yaml-front-matter')
 const mergeDeps = require('./util/mergeDeps')
-const { isOfficialPlugin, toShortPluginId } = require('@vue/cli-shared-utils')
+const { getPluginLink, toShortPluginId } = require('@vue/cli-shared-utils')
 
 const isString = val => typeof val === 'string'
 const isFunction = val => typeof val === 'function'
 const isObject = val => val && typeof val === 'object'
 
-// get link for a 3rd party plugin.
-function getLink (id) {
-  let pkg = {}
-  try {
-    pkg = require(`${id}/package.json`)
-  } catch (e) {}
-  return (
-    pkg.homepage ||
-    (pkg.repository && pkg.repository.url) ||
-    `https://www.npmjs.com/package/${id.replace(`/`, `%2F`)}`
-  )
-}
-
 class GeneratorAPI {
   /**
    * @param {string} id - Id of the owner plugin
@@ -39,15 +26,10 @@ class GeneratorAPI {
 
     this.pluginsData = generator.plugins
       .filter(({ id }) => id !== `@vue/cli-service`)
-      .map(({ id }) => {
-        const name = toShortPluginId(id)
-        return {
-          name: name,
-          link: isOfficialPlugin(id)
-            ? `https://github.com/vuejs/vue-cli/tree/dev/packages/%40vue/cli-plugin-${name}`
-            : getLink(id)
-        }
-      })
+      .map(({ id }) => ({
+        name: toShortPluginId(id),
+        link: getPluginLink(id)
+      }))
   }
 
   /**
