Better handling of publicPath: 'auto' (#7005)

AndreiSoroka · web-flow · commit c5cfefbb072e · 2022-03-22T22:11:02.000+08:00
diff --git a/packages/@vue/cli-service/lib/commands/serve.js b/packages/@vue/cli-service/lib/commands/serve.js
@@ -5,6 +5,7 @@ const {
   hasProjectPnpm,
   IpcMessenger
 } = require('@vue/cli-shared-utils')
+const getBaseUrl = require('../util/getBaseUrl')
 
 const defaults = {
   host: '0.0.0.0',
@@ -14,6 +15,7 @@ const defaults = {
 
 /** @type {import('@vue/cli-service').ServicePlugin} */
 module.exports = (api, options) => {
+  const baseUrl = getBaseUrl(options)
   api.registerCommand('serve', {
     description: 'start development server',
     usage: 'vue-cli-service serve [options] [entry]',
@@ -116,7 +118,7 @@ module.exports = (api, options) => {
       protocol,
       host,
       port,
-      isAbsoluteUrl(options.publicPath) ? '/' : options.publicPath
+      isAbsoluteUrl(baseUrl) ? '/' : baseUrl
     )
     const localUrlForBrowser = publicUrl || urls.localUrlForBrowser
 
@@ -187,7 +189,7 @@ module.exports = (api, options) => {
           'text/html',
           'application/xhtml+xml'
         ],
-        rewrites: genHistoryApiFallbackRewrites(options.publicPath, options.pages)
+        rewrites: genHistoryApiFallbackRewrites(baseUrl, options.pages)
       },
       hot: !isProduction
     }, projectDevServerOptions, {
diff --git a/packages/@vue/cli-service/lib/util/getBaseUrl.js b/packages/@vue/cli-service/lib/util/getBaseUrl.js
@@ -0,0 +1,3 @@
+module.exports = function getBaseUrl (options) {
+  return options.publicPath === 'auto' ? '' : options.publicPath
+}
diff --git a/packages/@vue/cli-service/lib/util/resolveClientEnv.js b/packages/@vue/cli-service/lib/util/resolveClientEnv.js
@@ -1,3 +1,4 @@
+const getBaseUrl = require('./getBaseUrl')
 const prefixRE = /^VUE_APP_/
 
 module.exports = function resolveClientEnv (options, raw) {
@@ -7,7 +8,7 @@ module.exports = function resolveClientEnv (options, raw) {
       env[key] = process.env[key]
     }
   })
-  env.BASE_URL = options.publicPath
+  env.BASE_URL = getBaseUrl(options)
 
   if (raw) {
     return env

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+module.exports = function getBaseUrl (options) {`
	`2`	`+ return options.publicPath === 'auto' ? '' : options.publicPath`
	`3`	`+}`