Show job text in ItemView rather than Item.

Dan Hersam · Dan Hersam · commit 4c48b64feb2b · 2015-10-30T13:18:45.000-04:00
I think this makes it cleaner, and job text isn't shown in the NewsView.

Also, using v-if rather than v-show since item type won't change at
runtime.
diff --git a/src/components/Item.vue b/src/components/Item.vue
@@ -17,7 +17,6 @@
         | <a :href="'#/item/' + item.id">{{item.descendants}} {{item.descendants | pluralize 'comment'}}</a>
       </span>
     </p>
-    <p class="jobtext" v-show="isJob" v-html="item.text"></p>
   </div>
 </template>
 
@@ -40,9 +39,6 @@ export default {
     },
     showDomain () {
       return this.item.type === 'story'
-    },
-    isJob () {
-      return this.item.type === 'job'
     }
   }
 }
@@ -73,9 +69,4 @@ export default {
       color $gray
   .subtext a:hover
     text-decoration underline
-  .jobtext
-    color $gray
-    padding-top 5px
-  .jobtext p
-    margin 10px 0
 </style>
diff --git a/src/components/ItemView.vue b/src/components/ItemView.vue
@@ -1,6 +1,7 @@
 <template>
   <div class="item-view" v-show="item">
     <item :item="item"></item>
+    <p class="jobtext" v-if="isJob" v-html="item.text"></p>
     <ul class="poll-options" v-if="pollOptions">
       <li v-for="option in pollOptions">
         <p>{{option.text}}</p>
@@ -13,7 +14,7 @@
         :comment="comment">
       </comment>
     </ul>
-    <p v-show="!comments.length && item.type !== 'job'">No comments yet.</p>
+    <p v-show="!comments.length && !isJob">No comments yet.</p>
   </div>
 </template>
 
@@ -50,6 +51,12 @@ export default {
           : null
       }))
     }
+  },
+
+  computed: {
+    isJob () {
+      return this.item.type === 'job'
+    }
   }
 }
 </script>
@@ -73,4 +80,9 @@ export default {
     .subtext
       color $gray
       font-size 11px
+  .jobtext
+    color $gray
+    margin-top 0
+  .jobtext p
+    margin 10px 0
 </style>
