refactor: use import type

haoqunjiang · haoqunjiang · commit 2eccc0efdfbb · 2021-09-23T09:55:25.000+08:00
Now that we don't depend on `@vue/compiler-sfc` directly, we should only
import types from the package, in case of accidentally depending on the
unlisted dependency.
diff --git a/src/descriptorCache.ts b/src/descriptorCache.ts
@@ -1,5 +1,5 @@
 import * as fs from 'fs'
-import { SFCDescriptor } from '@vue/compiler-sfc'
+import type { SFCDescriptor } from '@vue/compiler-sfc'
 import { compiler } from './compiler'
 
 const cache = new Map<string, SFCDescriptor>()
diff --git a/src/formatError.ts b/src/formatError.ts
@@ -1,4 +1,4 @@
-import { CompilerError } from '@vue/compiler-sfc'
+import type { CompilerError } from '@vue/compiler-sfc'
 import { compiler } from './compiler'
 import chalk = require('chalk')
 
diff --git a/src/index.ts b/src/index.ts
@@ -6,7 +6,7 @@ import * as loaderUtils from 'loader-utils'
 import hash = require('hash-sum')
 
 import { compiler } from './compiler'
-import {
+import type {
   TemplateCompiler,
   CompilerOptions,
   SFCBlock,
diff --git a/src/pluginWebpack4.ts b/src/pluginWebpack4.ts
@@ -1,6 +1,6 @@
 import * as qs from 'querystring'
 import webpack = require('webpack')
-import { VueLoaderOptions } from './'
+import type { VueLoaderOptions } from './'
 
 const RuleSet = require('webpack/lib/RuleSet')
 
diff --git a/src/pluginWebpack5.ts b/src/pluginWebpack5.ts
@@ -1,6 +1,6 @@
 import * as qs from 'querystring'
-import { VueLoaderOptions } from './'
-import { RuleSetRule, Compiler, Plugin } from 'webpack'
+import type { VueLoaderOptions } from './'
+import type { RuleSetRule, Compiler, Plugin } from 'webpack'
 
 const id = 'vue-loader-plugin'
 const NS = 'vue-loader'
diff --git a/src/resolveScript.ts b/src/resolveScript.ts
@@ -1,10 +1,10 @@
 import webpack = require('webpack')
-import {
+import type {
   SFCDescriptor,
   SFCScriptBlock,
   TemplateCompiler,
 } from '@vue/compiler-sfc'
-import { VueLoaderOptions } from 'src'
+import type { VueLoaderOptions } from 'src'
 import { resolveTemplateTSOptions } from './util'
 import { compiler } from './compiler'
 
diff --git a/src/select.ts b/src/select.ts
@@ -1,8 +1,8 @@
 import webpack = require('webpack')
-import { SFCDescriptor } from '@vue/compiler-sfc'
-import { ParsedUrlQuery } from 'querystring'
+import type { SFCDescriptor } from '@vue/compiler-sfc'
+import type { ParsedUrlQuery } from 'querystring'
 import { resolveScript } from './resolveScript'
-import { VueLoaderOptions } from 'src'
+import type { VueLoaderOptions } from 'src'
 
 export function selectBlock(
   descriptor: SFCDescriptor,
diff --git a/src/templateLoader.ts b/src/templateLoader.ts
@@ -3,7 +3,7 @@ import * as qs from 'querystring'
 import * as loaderUtils from 'loader-utils'
 import { VueLoaderOptions } from './'
 import { formatError } from './formatError'
-import { TemplateCompiler } from '@vue/compiler-sfc'
+import type { TemplateCompiler } from '@vue/compiler-sfc'
 import { getDescriptor } from './descriptorCache'
 import { resolveScript } from './resolveScript'
 import { resolveTemplateTSOptions } from './util'
diff --git a/src/util.ts b/src/util.ts
@@ -1,5 +1,5 @@
-import { SFCDescriptor, CompilerOptions } from '@vue/compiler-sfc'
-import { VueLoaderOptions } from '.'
+import type { SFCDescriptor, CompilerOptions } from '@vue/compiler-sfc'
+import type { VueLoaderOptions } from '.'
 
 export function resolveTemplateTSOptions(
   descriptor: SFCDescriptor,

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { CompilerError } from '@vue/compiler-sfc'`
	`1`	`+import type { CompilerError } from '@vue/compiler-sfc'`
`2`	`2`	`import { compiler } from './compiler'`
`3`	`3`	`import chalk = require('chalk')`
`4`	`4`