fix: properly close the watcher after tests

haoqunjiang · haoqunjiang · commit 40b93b9c2722 · 2023-05-28T22:39:22.000+08:00
diff --git a/src/pluginWebpack4.ts b/src/pluginWebpack4.ts
@@ -171,6 +171,15 @@ class VueLoaderPlugin {
           watcher.close()
         }
       })
+
+      // In some cases, e.g. in this project's tests,
+      // even though needsHMR() returns true, webpack is not watching, thus no watchClose hook is called.
+      // So we need to close the watcher when webpack is done.
+      compiler.hooks.done.tap(id, () => {
+        if (watcher) {
+          watcher.close()
+        }
+      })
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,15 @@ class VueLoaderPlugin {`
`171`	`171`	`watcher.close()`
`172`	`172`	`}`
`173`	`173`	`})`
	`174`	`+`
	`175`	`+ // In some cases, e.g. in this project's tests,`
	`176`	`+ // even though needsHMR() returns true, webpack is not watching, thus no watchClose hook is called.`
	`177`	`+ // So we need to close the watcher when webpack is done.`
	`178`	`+ compiler.hooks.done.tap(id, () => {`
	`179`	`+ if (watcher) {`
	`180`	`+ watcher.close()`
	`181`	`+ }`
	`182`	`+ })`
`174`	`183`	`}`
`175`	`184`	`}`
`176`	`185`	`}`