Testing random insert properly.

lygstate · lygstate · commit aa997d38608b · 2015-09-23T11:12:53.000+08:00
diff --git a/src/data-structures/size-balanced-tree.js b/src/data-structures/size-balanced-tree.js
@@ -231,7 +231,7 @@
       newNode = new Node(value, node, Nil, Nil, 1);
       node.left = newNode;
     } else {
-      node = findRightMost(node);
+      node = findRightMost(node.left);
       newNode = new Node(value, node, Nil, Nil, 1);
       node.right = newNode;
     }
diff --git a/test/data-structures/size-balanced-tree.spec.js b/test/data-structures/size-balanced-tree.spec.js
@@ -88,14 +88,24 @@ describe('SBTree', function () {
     expect(right.parent).toBe(Nil);
     checkNil();
   });
+  // Returns a random integer between min (included) and max (excluded)
+  // Using Math.round() will give you a non-uniform distribution!
+  function getRandomInt(min, max) {
+    return Math.floor(Math.random() * (max - min)) + min;
+  }
+  // Returns a random integer between min (included) and max (included)
+  // Using Math.round() will give you a non-uniform distribution!
+  function getRandomIntInclusive(min, max) {
+    return Math.floor(Math.random() * (max - min + 1)) + min;
+  }
 
   it('push and get 100000 elements, remove the array by always remove the first/last element', function () {
     var sTree = new SBTree();
     for (var i = 0; i < 2000000; ++i) {
       sTree.push(i);
     }
     checkNil();
-    let maxHeight = 0;
+    var maxHeight = 0;
     for (var i = 0; i < 2000000; ++i) {
       var node = sTree.get(i);
       maxHeight = Math.max(maxHeight, node.height);
@@ -119,5 +129,31 @@ describe('SBTree', function () {
       expect(sTree.size).toBe(count - i - 1);
     }
     checkNil();
+    var expectedArray = [];
+    for (var i = 0; i < 10000; ++i) {
+      var isAdded = sTree.size === 0;
+      if (!isAdded) {
+        isAdded = getRandomIntInclusive(0, 3) < 3;
+      }
+      if (isAdded) {
+        var newPos = getRandomIntInclusive(0, sTree.size);
+        sTree.insert(newPos, i);
+        expectedArray.splice(newPos, 0, i);
+      } else {
+        var removedPos = getRandomInt(0, sTree.size);
+       // sTree.remove(removedPos);
+        //expectedArray.splice(removedPos, 1);
+      }
+    }
+    expect(sTree.size).toBe(expectedArray.length);
+    maxHeight = 0;
+    for (var i = 0; i < sTree.size; ++i) {
+      var node = sTree.get(i);
+      maxHeight = Math.max(maxHeight, node.height);
+      expect(node.value).toBe(expectedArray[i]);
+      //console.log(node.value, expectedArray[i]);
+    }
+    console.log(maxHeight);
+    checkNil();
   });
 });

Original file line number	Diff line number	Diff line change
`@@ -231,7 +231,7 @@`
`231`	`231`	`newNode = new Node(value, node, Nil, Nil, 1);`
`232`	`232`	`node.left = newNode;`
`233`	`233`	`} else {`
`234`		`- node = findRightMost(node);`
	`234`	`+ node = findRightMost(node.left);`
`235`	`235`	`newNode = new Node(value, node, Nil, Nil, 1);`
`236`	`236`	`node.right = newNode;`
`237`	`237`	`}`